Author: todd
Date: Fri Nov 11 21:16:16 2011
New Revision: 1201055
URL: http://svn.apache.org/viewvc?rev=1201055&view=rev
Log:
HADOOP-7813. Fix test-patch to use proper numerical comparison when checking
javadoc and findbugs warning counts. Contributed by Jonathan Eagles.
Modified:
hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
Modified: hadoop/common/branches/branch-0.23/dev-support/test-patch.sh
URL:
http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.23/dev-support/test-patch.sh?rev=1201055&r1=1201054&r2=1201055&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.23/dev-support/test-patch.sh (original)
+++ hadoop/common/branches/branch-0.23/dev-support/test-patch.sh Fri Nov 11
21:16:16 2011
@@ -396,7 +396,7 @@ checkJavadocWarnings () {
echo "There appear to be $javadocWarnings javadoc warnings generated by the
patched build."
### if current warnings greater than OK_JAVADOC_WARNINGS
- if [[ $javadocWarnings > $OK_JAVADOC_WARNINGS ]] ; then
+ if [[ $javadocWarnings -gt $OK_JAVADOC_WARNINGS ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
-1 javadoc. The javadoc tool appears to have generated `expr
$(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
@@ -571,7 +571,7 @@ $JIRA_COMMENT_FOOTER"
done
### if current warnings greater than OK_FINDBUGS_WARNINGS
- if [[ $findbugsWarnings > $OK_FINDBUGS_WARNINGS ]] ; then
+ if [[ $findbugsWarnings -gt $OK_FINDBUGS_WARNINGS ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
-1 findbugs. The patch appears to introduce `expr
$(($findbugsWarnings-$OK_FINDBUGS_WARNINGS))` new Findbugs (version
${findbugs_version}) warnings."
