Author: sandy
Date: Fri Jun 13 20:45:24 2014
New Revision: 1602516
URL: http://svn.apache.org/r1602516
Log:
HADOOP-10688. Expose thread-level FileSystem StatisticsData (Sandy Ryza)
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1602516&r1=1602515&r2=1602516&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
(original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Fri Jun
13 20:45:24 2014
@@ -425,6 +425,8 @@ Release 2.5.0 - UNRELEASED
HADOOP-10691. Improve the readability of 'hadoop fs -help'.
(Lei Xu via wang)
+ HADOOP-10688. Expose thread-level FileSystem StatisticsData (Sandy Ryza)
+
OPTIMIZATIONS
BUG FIXES
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java?rev=1602516&r1=1602515&r2=1602516&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
(original)
+++
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
Fri Jun 13 20:45:24 2014
@@ -2804,7 +2804,7 @@ public abstract class FileSystem extends
* be perceived as atomic with respect to other threads, which is all we
* need.
*/
- private static class StatisticsData {
+ public static class StatisticsData {
volatile long bytesRead;
volatile long bytesWritten;
volatile int readOps;
@@ -2849,6 +2849,26 @@ public abstract class FileSystem extends
+ readOps + " read ops, " + largeReadOps + " large read ops, "
+ writeOps + " write ops";
}
+
+ public long getBytesRead() {
+ return bytesRead;
+ }
+
+ public long getBytesWritten() {
+ return bytesWritten;
+ }
+
+ public int getReadOps() {
+ return readOps;
+ }
+
+ public int getLargeReadOps() {
+ return largeReadOps;
+ }
+
+ public int getWriteOps() {
+ return writeOps;
+ }
}
private interface StatisticsAggregator<T> {
@@ -2907,7 +2927,7 @@ public abstract class FileSystem extends
/**
* Get or create the thread-local data associated with the current thread.
*/
- private StatisticsData getThreadData() {
+ public StatisticsData getThreadStatistics() {
StatisticsData data = threadData.get();
if (data == null) {
data = new StatisticsData(
@@ -2928,7 +2948,7 @@ public abstract class FileSystem extends
* @param newBytes the additional bytes read
*/
public void incrementBytesRead(long newBytes) {
- getThreadData().bytesRead += newBytes;
+ getThreadStatistics().bytesRead += newBytes;
}
/**
@@ -2936,7 +2956,7 @@ public abstract class FileSystem extends
* @param newBytes the additional bytes written
*/
public void incrementBytesWritten(long newBytes) {
- getThreadData().bytesWritten += newBytes;
+ getThreadStatistics().bytesWritten += newBytes;
}
/**
@@ -2944,7 +2964,7 @@ public abstract class FileSystem extends
* @param count number of read operations
*/
public void incrementReadOps(int count) {
- getThreadData().readOps += count;
+ getThreadStatistics().readOps += count;
}
/**
@@ -2952,7 +2972,7 @@ public abstract class FileSystem extends
* @param count number of large read operations
*/
public void incrementLargeReadOps(int count) {
- getThreadData().largeReadOps += count;
+ getThreadStatistics().largeReadOps += count;
}
/**
@@ -2960,7 +2980,7 @@ public abstract class FileSystem extends
* @param count number of write operations
*/
public void incrementWriteOps(int count) {
- getThreadData().writeOps += count;
+ getThreadStatistics().writeOps += count;
}
/**