http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java index 9923806..bfe10d6 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/AMRMClient.java @@ -349,7 +349,7 @@ public abstract class AMRMClient<T extends AMRMClient.ContainerRequest> extends * Set the NM token cache for the <code>AMRMClient</code>. This cache must * be shared with the {@link NMClient} used to manage containers for the * <code>AMRMClient</code> - * <p/> + * <p> * If a NM token cache is not set, the {@link NMTokenCache#getSingleton()} * singleton instance will be used. * @@ -363,7 +363,7 @@ public abstract class AMRMClient<T extends AMRMClient.ContainerRequest> extends * Get the NM token cache of the <code>AMRMClient</code>. This cache must be * shared with the {@link NMClient} used to manage containers for the * <code>AMRMClient</code>. - * <p/> + * <p> * If a NM token cache is not set, the {@link NMTokenCache#getSingleton()} * singleton instance will be used. *
http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java index 721728e..08b911b 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMClient.java @@ -125,7 +125,7 @@ public abstract class NMClient extends AbstractService { * Set the NM Token cache of the <code>NMClient</code>. This cache must be * shared with the {@link AMRMClient} that requested the containers managed * by this <code>NMClient</code> - * <p/> + * <p> * If a NM token cache is not set, the {@link NMTokenCache#getSingleton()} * singleton instance will be used. * @@ -139,7 +139,7 @@ public abstract class NMClient extends AbstractService { * Get the NM token cache of the <code>NMClient</code>. This cache must be * shared with the {@link AMRMClient} that requested the containers managed * by this <code>NMClient</code> - * <p/> + * <p> * If a NM token cache is not set, the {@link NMTokenCache#getSingleton()} * singleton instance will be used. * http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMTokenCache.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMTokenCache.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMTokenCache.java index 0e7356f..0c349cc 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMTokenCache.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/NMTokenCache.java @@ -34,26 +34,26 @@ import com.google.common.annotations.VisibleForTesting; /** * NMTokenCache manages NMTokens required for an Application Master * communicating with individual NodeManagers. - * <p/> + * <p> * By default Yarn client libraries {@link AMRMClient} and {@link NMClient} use * {@link #getSingleton()} instance of the cache. * <ul> - * <li>Using the singleton instance of the cache is appropriate when running a - * single ApplicationMaster in the same JVM.</li> - * <li>When using the singleton, users don't need to do anything special, - * {@link AMRMClient} and {@link NMClient} are already set up to use the default - * singleton {@link NMTokenCache}</li> + * <li> + * Using the singleton instance of the cache is appropriate when running a + * single ApplicationMaster in the same JVM. + * </li> + * <li> + * When using the singleton, users don't need to do anything special, + * {@link AMRMClient} and {@link NMClient} are already set up to use the + * default singleton {@link NMTokenCache} + * </li> * </ul> - * <p/> * If running multiple Application Masters in the same JVM, a different cache * instance should be used for each Application Master. - * <p/> * <ul> - * <li> - * If using the {@link AMRMClient} and the {@link NMClient}, setting up and using - * an instance cache is as follows: - * <p/> - * + * <li> + * If using the {@link AMRMClient} and the {@link NMClient}, setting up + * and using an instance cache is as follows: * <pre> * NMTokenCache nmTokenCache = new NMTokenCache(); * AMRMClient rmClient = AMRMClient.createAMRMClient(); @@ -61,12 +61,10 @@ import com.google.common.annotations.VisibleForTesting; * nmClient.setNMTokenCache(nmTokenCache); * ... * </pre> - * </li> - * <li> - * If using the {@link AMRMClientAsync} and the {@link NMClientAsync}, setting up - * and using an instance cache is as follows: - * <p/> - * + * </li> + * <li> + * If using the {@link AMRMClientAsync} and the {@link NMClientAsync}, + * setting up and using an instance cache is as follows: * <pre> * NMTokenCache nmTokenCache = new NMTokenCache(); * AMRMClient rmClient = AMRMClient.createAMRMClient(); @@ -76,13 +74,11 @@ import com.google.common.annotations.VisibleForTesting; * NMClientAsync nmClientAsync = new NMClientAsync("nmClient", nmClient, [NM_CALLBACK]); * ... * </pre> - * </li> - * <li> - * If using {@link ApplicationMasterProtocol} and - * {@link ContainerManagementProtocol} directly, setting up and using an - * instance cache is as follows: - * <p/> - * + * </li> + * <li> + * If using {@link ApplicationMasterProtocol} and + * {@link ContainerManagementProtocol} directly, setting up and using an + * instance cache is as follows: * <pre> * NMTokenCache nmTokenCache = new NMTokenCache(); * ... @@ -100,12 +96,12 @@ import com.google.common.annotations.VisibleForTesting; * nmPro.startContainer(container, containerContext); * ... * </pre> - * </li> + * </li> * </ul> - * It is also possible to mix the usage of a client (<code>AMRMClient</code> or - * <code>NMClient</code>, or the async versions of them) with a protocol proxy ( - * <code>ContainerManagementProtocolProxy</code> or - * <code>ApplicationMasterProtocol</code>). + * It is also possible to mix the usage of a client ({@code AMRMClient} or + * {@code NMClient}, or the async versions of them) with a protocol proxy + * ({@code ContainerManagementProtocolProxy} or + * {@code ApplicationMasterProtocol}). */ @Public @Evolving http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java index d96761a..f617731 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java @@ -32,14 +32,12 @@ import org.apache.hadoop.classification.InterfaceStability.Unstable; import org.apache.hadoop.io.Text; import org.apache.hadoop.service.AbstractService; import org.apache.hadoop.yarn.api.ApplicationClientProtocol; -import org.apache.hadoop.yarn.api.protocolrecords.GetApplicationReportRequest; import org.apache.hadoop.yarn.api.protocolrecords.ReservationDeleteRequest; import org.apache.hadoop.yarn.api.protocolrecords.ReservationDeleteResponse; import org.apache.hadoop.yarn.api.protocolrecords.ReservationSubmissionRequest; import org.apache.hadoop.yarn.api.protocolrecords.ReservationSubmissionResponse; import org.apache.hadoop.yarn.api.protocolrecords.ReservationUpdateRequest; import org.apache.hadoop.yarn.api.protocolrecords.ReservationUpdateResponse; -import org.apache.hadoop.yarn.api.protocolrecords.SubmitApplicationRequest; import org.apache.hadoop.yarn.api.records.ApplicationAttemptId; import org.apache.hadoop.yarn.api.records.ApplicationAttemptReport; import org.apache.hadoop.yarn.api.records.ApplicationId; @@ -58,8 +56,10 @@ import org.apache.hadoop.yarn.api.records.Token; import org.apache.hadoop.yarn.api.records.YarnApplicationState; import org.apache.hadoop.yarn.api.records.YarnClusterMetrics; import org.apache.hadoop.yarn.client.api.impl.YarnClientImpl; +import org.apache.hadoop.yarn.exceptions.ApplicationAttemptNotFoundException; import org.apache.hadoop.yarn.exceptions.ApplicationIdNotProvidedException; import org.apache.hadoop.yarn.exceptions.ApplicationNotFoundException; +import org.apache.hadoop.yarn.exceptions.ContainerNotFoundException; import org.apache.hadoop.yarn.exceptions.YarnException; import org.apache.hadoop.yarn.security.AMRMTokenIdentifier; @@ -171,7 +171,6 @@ public abstract class YarnClient extends AbstractService { * <li>original tracking URL - set to "N/A"</li> * <li>resource usage report - all values are -1</li> * </ul> - * </p> * * @param appId * {@link ApplicationId} of the application that needs a report @@ -184,20 +183,20 @@ public abstract class YarnClient extends AbstractService { /** * Get the AMRM token of the application. - * <p/> + * <p> * The AMRM token is required for AM to RM scheduling operations. For * managed Application Masters Yarn takes care of injecting it. For unmanaged * Applications Masters, the token must be obtained via this method and set * in the {@link org.apache.hadoop.security.UserGroupInformation} of the * current user. - * <p/> + * <p> * The AMRM token will be returned only if all the following conditions are * met: - * <li> - * <ul>the requester is the owner of the ApplicationMaster</ul> - * <ul>the application master is an unmanaged ApplicationMaster</ul> - * <ul>the application master is in ACCEPTED state</ul> - * </li> + * <ul> + * <li>the requester is the owner of the ApplicationMaster</li> + * <li>the application master is an unmanaged ApplicationMaster</li> + * <li>the application master is in ACCEPTED state</li> + * </ul> * Else this method returns NULL. * * @param appId {@link ApplicationId} of the application to get the AMRM token @@ -415,7 +414,7 @@ public abstract class YarnClient extends AbstractService { * a report * @return application attempt report * @throws YarnException - * @throws {@link ApplicationAttemptNotFoundException} if application attempt + * @throws ApplicationAttemptNotFoundException if application attempt * not found * @throws IOException */ @@ -450,7 +449,7 @@ public abstract class YarnClient extends AbstractService { * {@link ContainerId} of the container that needs a report * @return container report * @throws YarnException - * @throws {@link ContainerNotFoundException} if container not found. + * @throws ContainerNotFoundException if container not found. * @throws IOException */ public abstract ContainerReport getContainerReport(ContainerId containerId) http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java index e2da664..67a5494 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java @@ -344,7 +344,7 @@ public class CommonNodeLabelsManager extends AbstractService { /** * add more labels to nodes * - * @param addedLabelsToNode node -> labels map + * @param addedLabelsToNode node {@literal ->} labels map */ public void addLabelsToNode(Map<NodeId, Set<String>> addedLabelsToNode) throws IOException { @@ -614,7 +614,7 @@ public class CommonNodeLabelsManager extends AbstractService { * remove labels from nodes, labels being removed most be contained by these * nodes * - * @param removeLabelsFromNode node -> labels map + * @param removeLabelsFromNode node {@literal ->} labels map */ public void removeLabelsFromNode(Map<NodeId, Set<String>> removeLabelsFromNode) @@ -668,7 +668,7 @@ public class CommonNodeLabelsManager extends AbstractService { /** * replace labels to nodes * - * @param replaceLabelsToNode node -> labels map + * @param replaceLabelsToNode node {@literal ->} labels map */ public void replaceLabelsOnNode(Map<NodeId, Set<String>> replaceLabelsToNode) throws IOException { http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java index 857d81b..4a34a09 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/NodeLabelsStore.java @@ -35,7 +35,7 @@ public abstract class NodeLabelsStore implements Closeable { } /** - * Store node -> label + * Store node {@literal ->} label */ public abstract void updateNodeToLabelsMappings( Map<NodeId, Set<String>> nodeToLabels) throws IOException; @@ -54,7 +54,6 @@ public abstract class NodeLabelsStore implements Closeable { /** * Recover labels and node to labels mappings from store - * @param conf */ public abstract void recover() throws IOException; http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java index 4cacfca..4daaa68 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/security/ApplicationACLsManager.java @@ -93,7 +93,6 @@ public class ApplicationACLsManager { * @param applicationAccessType * @param applicationOwner * @param applicationId - * @throws AccessControlException */ public boolean checkAccess(UserGroupInformation callerUGI, ApplicationAccessType applicationAccessType, String applicationOwner, http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/StringHelper.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/StringHelper.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/StringHelper.java index e6f23f0..3343a17 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/StringHelper.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/StringHelper.java @@ -88,7 +88,7 @@ public final class StringHelper { } /** - * Join on slash & colon (e.g., path args in routing spec) + * Join on slash and colon (e.g., path args in routing spec) * @param args to join * @return args joined with /: */ @@ -116,7 +116,7 @@ public final class StringHelper { } /** - * Split on space & trim results. + * Split on space and trim results. * @param s the string to split * @return an iterable of strings */ @@ -125,7 +125,7 @@ public final class StringHelper { } /** - * Split on _ & trim results + * Split on _ and trim results * @param s the string to split * @return an iterable of strings */ http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java index 1b5840f..bda24aa 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java @@ -52,13 +52,13 @@ import com.google.inject.servlet.GuiceFilter; /** * Helpers to create an embedded webapp. * - * <h4>Quick start:</h4> + * <b>Quick start:</b> * <pre> * WebApp wa = WebApps.$for(myApp).start();</pre> * Starts a webapp with default routes binds to 0.0.0.0 (all network interfaces) * on an ephemeral port, which can be obtained with:<pre> * int port = wa.port();</pre> - * <h4>With more options:</h4> + * <b>With more options:</b> * <pre> * WebApp wa = WebApps.$for(myApp).at(address, port). * with(configuration). http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/binding/RegistryUtils.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/binding/RegistryUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/binding/RegistryUtils.java index 06a56d8..858b6b1 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/binding/RegistryUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/binding/RegistryUtils.java @@ -116,10 +116,10 @@ public class RegistryUtils { } /** - * Create a path to a service under a user & service class + * Create a path to a service under a user and service class * @param user username or "" * @param serviceClass service name - * @param serviceName service name unique for that user & service class + * @param serviceName service name unique for that user and service class * @return a full path */ public static String servicePath(String user, @@ -135,7 +135,7 @@ public class RegistryUtils { * Create a path for listing components under a service * @param user username or "" * @param serviceClass service name - * @param serviceName service name unique for that user & service class + * @param serviceName service name unique for that user and service class * @return a full path */ public static String componentListPath(String user, @@ -149,7 +149,7 @@ public class RegistryUtils { * Create the path to a service record for a component * @param user username or "" * @param serviceClass service name - * @param serviceName service name unique for that user & service class + * @param serviceName service name unique for that user and service class * @param componentName unique name/ID of the component * @return a full path */ http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/RegistryOperationsClient.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/RegistryOperationsClient.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/RegistryOperationsClient.java index db03936..44cefed 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/RegistryOperationsClient.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/RegistryOperationsClient.java @@ -32,7 +32,7 @@ import org.apache.hadoop.registry.client.impl.zk.RegistryOperationsService; * * For SASL, the client must be operating in the context of an authed user. * - * For id:pass the client must have the relevant id & password, SASL is + * For id:pass the client must have the relevant id and password, SASL is * not used even if the client has credentials. * * For anonymous, nothing is used. http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ZookeeperConfigOptions.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ZookeeperConfigOptions.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ZookeeperConfigOptions.java index d81f24b..edcf085 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ZookeeperConfigOptions.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ZookeeperConfigOptions.java @@ -71,14 +71,13 @@ public interface ZookeeperConfigOptions { * The SASL client username: {@value}. * <p> * Set this to the <i>short</i> name of the client, e.g, "user", - * not <code>user/host</code>, or <code>user/host@REALM</code> + * not {@code user/host}, or {@code user/host@REALM} */ String PROP_ZK_SASL_CLIENT_USERNAME = "zookeeper.sasl.client.username"; /** * The SASL Server context, referring to a context in the JVM's * JAAS context file: {@value} - * <p> */ String PROP_ZK_SERVER_SASL_CONTEXT = ZooKeeperSaslServer.LOGIN_CONTEXT_NAME_KEY; http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/MicroZookeeperService.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/MicroZookeeperService.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/MicroZookeeperService.java index 3fa0c19..88e9d67 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/MicroZookeeperService.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/MicroZookeeperService.java @@ -47,16 +47,16 @@ import java.net.UnknownHostException; /** * This is a small, localhost Zookeeper service instance that is contained * in a YARN service...it's been derived from Apache Twill. - * + * <p> * It implements {@link RegistryBindingSource} and provides binding information, - * <i>once started</i>. Until <code>start()</code> is called, the hostname & + * <i>once started</i>. Until {@link #start()} is called, the hostname and * port may be undefined. Accordingly, the service raises an exception in this * condition. - * + * <p> * If you wish to chain together a registry service with this one under - * the same <code>CompositeService</code>, this service must be added + * the same {@code CompositeService}, this service must be added * as a child first. - * + * <p> * It also sets the configuration parameter * {@link RegistryConstants#KEY_REGISTRY_ZK_QUORUM} * to its connection string. Any code with access to the service configuration http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/package-info.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/package-info.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/package-info.java index 85d24b3..fe2a0a8 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/package-info.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/package-info.java @@ -19,9 +19,10 @@ /** * Basic services for the YARN registry * <ul> - * <li>The {@link org.apache.hadoop.registry.server.services.RegistryAdminService}</ol> - * extends the shared Yarn Registry client with registry setup and - * (potentially asynchronous) administrative actions. + * <li> + * The {@link org.apache.hadoop.registry.server.services.RegistryAdminService} + * extends the shared Yarn Registry client with registry setup and + * (potentially asynchronous) administrative actions. * </li> * <li> * The {@link org.apache.hadoop.registry.server.services.MicroZookeeperService} @@ -33,8 +34,6 @@ * extends the standard YARN composite service by making its add and remove * methods public. It is a utility service used in parts of the codebase * </li> - * * </ul> - * */ package org.apache.hadoop.registry.server.services; http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java index 39c10fb..1ee8181 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java @@ -45,17 +45,15 @@ import org.apache.hadoop.yarn.security.client.TimelineDelegationTokenIdentifier; import com.google.common.annotations.VisibleForTesting; /** - * <p> * Initializes {@link TimelineAuthenticationFilter} which provides support for * Kerberos HTTP SPNEGO authentication. - * <p/> * <p> * It enables Kerberos HTTP SPNEGO plus delegation token authentication for the * timeline server. - * <p/> - * Refer to the <code>core-default.xml</code> file, after the comment 'HTTP + * <p> + * Refer to the {@code core-default.xml} file, after the comment 'HTTP * Authentication' for details on the configuration options. All related - * configuration properties have 'hadoop.http.authentication.' as prefix. + * configuration properties have {@code hadoop.http.authentication.} as prefix. */ public class TimelineAuthenticationFilterInitializer extends FilterInitializer { @@ -71,14 +69,11 @@ public class TimelineAuthenticationFilterInitializer extends FilterInitializer { Map<String, String> filterConfig; /** - * <p> * Initializes {@link TimelineAuthenticationFilter} - * <p/> * <p> * Propagates to {@link TimelineAuthenticationFilter} configuration all YARN * configuration properties prefixed with - * "yarn.timeline-service.authentication." - * </p> + * {@code yarn.timeline-service.authentication.} * * @param container * The filter container http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java index e675308..ba130c6 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java @@ -40,7 +40,7 @@ public class ZKClient { * the zookeeper client library to * talk to zookeeper * @param string the host - * @throws throws IOException + * @throws IOException */ public ZKClient(String string) throws IOException { zkClient = new ZooKeeper(string, 30000, new ZKWatcher()); http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerRequest.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerRequest.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerRequest.java index 0e3d7e4..366c32c 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerRequest.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/RegisterNodeManagerRequest.java @@ -52,7 +52,8 @@ public abstract class RegisterNodeManagerRequest { * We introduce this here because currently YARN RM doesn't persist nodes info * for application running. When RM restart happened, we cannot determinate if * a node should do application cleanup (like log-aggregation, status update, - * etc.) or not. <p/> + * etc.) or not. + * <p> * When we have this running application list in node manager register * request, we can recover nodes info for running applications. And then we * can take actions accordingly http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeHealthStatus.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeHealthStatus.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeHealthStatus.java index bc5825a..b21b880 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeHealthStatus.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeHealthStatus.java @@ -26,19 +26,17 @@ import org.apache.hadoop.yarn.api.records.NodeReport; import org.apache.hadoop.yarn.util.Records; /** - * <p><code>NodeHealthStatus</code> is a summary of the health status of the - * node.</p> - * - * <p>It includes information such as: - * <ul> - * <li> - * An indicator of whether the node is healthy, as determined by the - * health-check script. - * </li> - * <li>The previous time at which the health status was reported.</li> - * <li>A diagnostic report on the health status.</li> - * </ul> - * </p> + * {@code NodeHealthStatus} is a summary of the health status of the node. + * <p> + * It includes information such as: + * <ul> + * <li> + * An indicator of whether the node is healthy, as determined by the + * health-check script. + * </li> + * <li>The previous time at which the health status was reported.</li> + * <li>A diagnostic report on the health status.</li> + * </ul> * * @see NodeReport * @see ApplicationClientProtocol#getClusterNodes(org.apache.hadoop.yarn.api.protocolrecords.GetClusterNodesRequest) http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java index 248a393..377fd1d 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/ContainerExecutor.java @@ -102,13 +102,15 @@ public abstract class ContainerExecutor implements Configurable { /** * Prepare the environment for containers in this application to execute. + * <pre> * For $x in local.dirs * create $x/$user/$appId - * Copy $nmLocal/appTokens -> $N/$user/$appId + * Copy $nmLocal/appTokens {@literal ->} $N/$user/$appId * For $rsrc in private resources - * Copy $rsrc -> $N/$user/filecache/[idef] + * Copy $rsrc {@literal ->} $N/$user/filecache/[idef] * For $rsrc in job resources - * Copy $rsrc -> $N/$user/$appId/filecache/idef + * Copy $rsrc {@literal ->} $N/$user/$appId/filecache/idef + * </pre> * @param user user name of application owner * @param appId id of the application * @param nmPrivateContainerTokens path to localized credentials, rsrc by NM http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java index 431cf5d..77db1e3 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/util/NodeManagerHardwareUtils.java @@ -65,11 +65,11 @@ public class NodeManagerHardwareUtils { } /** - * Gets the percentage of physical CPU that is configured for YARN containers - * This is percent > 0 and <= 100 based on - * YarnConfiguration.NM_RESOURCE_PERCENTAGE_PHYSICAL_CPU_LIMIT + * Gets the percentage of physical CPU that is configured for YARN containers. + * This is percent {@literal >} 0 and {@literal <=} 100 based on + * {@link YarnConfiguration#NM_RESOURCE_PERCENTAGE_PHYSICAL_CPU_LIMIT} * @param conf Configuration object - * @return percent > 0 and <= 100 + * @return percent {@literal >} 0 and {@literal <=} 100 */ public static int getNodeCpuPercentage(Configuration conf) { int nodeCpuPercentage = http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java index cf8c2bb..b85174e 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java @@ -216,11 +216,14 @@ public interface RMAppAttempt extends EventHandler<RMAppAttemptEvent> { /** * Return the flag which indicates whether the attempt failure should be * counted to attempt retry count. - * <ul> + * <p> * There failure types should not be counted to attempt retry count: - * <li>preempted by the scheduler.</li> - * <li>hardware failures, such as NM failing, lost NM and NM disk errors.</li> - * <li>killed by RM because of RM restart or failover.</li> + * <ul> + * <li>preempted by the scheduler.</li> + * <li> + * hardware failures, such as NM failing, lost NM and NM disk errors. + * </li> + * <li>killed by RM because of RM restart or failover.</li> * </ul> */ boolean shouldCountTowardsMaxAttemptRetry(); http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java index 957e8f6..2901134 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java @@ -114,7 +114,7 @@ public abstract class SchedulerNode { /** * Get the name of the node for scheduling matching decisions. - * <p/> + * <p> * Typically this is the 'hostname' reported by the node, but it could be * configured to be 'hostname:port' reported by the node via the * {@link YarnConfiguration#RM_SCHEDULER_INCLUDE_PORT_IN_NODE_NAME} constant. http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java index 65d6859..248cc08 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java @@ -194,8 +194,7 @@ public class SchedulerUtils { * Utility method to validate a resource request, by insuring that the * requested memory/vcore is non-negative and not greater than max * - * @throws <code>InvalidResourceRequestException</code> when there is invalid - * request + * @throws InvalidResourceRequestException when there is invalid request */ public static void validateResourceRequest(ResourceRequest resReq, Resource maximumResource, String queueName, YarnScheduler scheduler) http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java index 3bea985..f4fad32 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java @@ -71,7 +71,7 @@ public class ComputeFairShares { * fair shares. The min and max shares and of the Schedulables are assumed to * be set beforehand. We compute the fairest possible allocation of shares to * the Schedulables that respects their min and max shares. - * + * <p> * To understand what this method does, we must first define what weighted * fair sharing means in the presence of min and max shares. If there * were no minimum or maximum shares, then weighted fair sharing would be @@ -79,30 +79,31 @@ public class ComputeFairShares { * Schedulable and all slots were assigned. Minimum and maximum shares add a * further twist - Some Schedulables may have a min share higher than their * assigned share or a max share lower than their assigned share. - * + * <p> * To deal with these possibilities, we define an assignment of slots as being * fair if there exists a ratio R such that: Schedulables S where S.minShare - * > R * S.weight are given share S.minShare - Schedulables S where S.maxShare - * < R * S.weight are given S.maxShare - All other Schedulables S are - * assigned share R * S.weight - The sum of all the shares is totalSlots. - * + * {@literal >} R * S.weight are given share S.minShare - Schedulables S + * where S.maxShare {@literal <} R * S.weight are given S.maxShare - + * All other Schedulables S are assigned share R * S.weight - + * The sum of all the shares is totalSlots. + * <p> * We call R the weight-to-slots ratio because it converts a Schedulable's * weight to the number of slots it is assigned. - * + * <p> * We compute a fair allocation by finding a suitable weight-to-slot ratio R. * To do this, we use binary search. Given a ratio R, we compute the number of * slots that would be used in total with this ratio (the sum of the shares * computed using the conditions above). If this number of slots is less than * totalSlots, then R is too small and more slots could be assigned. If the * number of slots is more than totalSlots, then R is too large. - * + * <p> * We begin the binary search with a lower bound on R of 0 (which means that * all Schedulables are only given their minShare) and an upper bound computed * to be large enough that too many slots are given (by doubling R until we * use more than totalResources resources). The helper method * resourceUsedWithWeightToResourceRatio computes the total resources used with a * given value of R. - * + * <p> * The running time of this algorithm is linear in the number of Schedulables, * because resourceUsedWithWeightToResourceRatio is linear-time and the number of * iterations of binary search is a constant (dependent on desired precision). http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java index dfcceb8..cb456d8 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java @@ -364,7 +364,6 @@ public class DelegationTokenRenewer extends AbstractService { * @param shouldCancelAtEnd true if tokens should be canceled when the app is * done else false. * @param user user - * @throws IOException */ public void addApplicationAsync(ApplicationId applicationId, Credentials ts, boolean shouldCancelAtEnd, String user) { @@ -634,7 +633,6 @@ public class DelegationTokenRenewer extends AbstractService { /** * removing failed DT - * @param applicationId */ private void removeFailedDelegationToken(DelegationTokenToRenew t) { ApplicationId applicationId = t.applicationId; http://git-wip-us.apache.org/repos/asf/hadoop/blob/3da9a97c/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java index d678edf..e130225 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/ProxyUriUtils.java @@ -181,7 +181,7 @@ public class ProxyUriUtils { /** * Returns the scheme if present in the url - * eg. "https://issues.apache.org/jira/browse/YARN" > "https" + * eg. "https://issues.apache.org/jira/browse/YARN" {@literal ->} "https" */ public static String getSchemeFromUrl(String url) { int index = 0;
