Repository: hadoop Updated Branches: refs/heads/trunk 1a495fbb4 -> cce66ba3c
HDFS-3918. EditLogTailer shouldn't log WARN when other node is in standby mode. Contributed by Todd Lipcon. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/cce66ba3 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/cce66ba3 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/cce66ba3 Branch: refs/heads/trunk Commit: cce66ba3c9ec293e8ba1afd0eb518c7ca0bbc7c9 Parents: 1a495fb Author: Harsh J <[email protected]> Authored: Tue Mar 31 08:04:18 2015 +0530 Committer: Harsh J <[email protected]> Committed: Tue Mar 31 08:04:18 2015 +0530 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../hadoop/hdfs/server/namenode/ha/EditLogTailer.java | 11 +++++++++++ 2 files changed, 14 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/cce66ba3/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 390d279..cba30b2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -323,6 +323,9 @@ Release 2.8.0 - UNRELEASED IMPROVEMENTS + HDFS-3918. EditLogTailer shouldn't log WARN when other node + is in standby mode (todd via harsh) + HDFS-4396. Add START_MSG/SHUTDOWN_MSG for ZKFC (Liang Xie via harsh) http://git-wip-us.apache.org/repos/asf/hadoop/blob/cce66ba3/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java index 6b6c8d4..1897d8d 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java @@ -42,6 +42,8 @@ import org.apache.hadoop.hdfs.server.namenode.FSNamesystem; import org.apache.hadoop.hdfs.server.namenode.NameNode; import org.apache.hadoop.hdfs.server.protocol.NamenodeProtocol; import org.apache.hadoop.ipc.RPC; +import org.apache.hadoop.ipc.RemoteException; +import org.apache.hadoop.ipc.StandbyException; import org.apache.hadoop.security.SecurityUtil; import static org.apache.hadoop.util.Time.monotonicNow; @@ -273,6 +275,15 @@ public class EditLogTailer { getActiveNodeProxy().rollEditLog(); lastRollTriggerTxId = lastLoadedTxnId; } catch (IOException ioe) { + if (ioe instanceof RemoteException) { + ioe = ((RemoteException)ioe).unwrapRemoteException(); + if (ioe instanceof StandbyException) { + LOG.info("Skipping log roll. Remote node is not in Active state: " + + ioe.getMessage().split("\n")[0]); + return; + } + } + LOG.warn("Unable to trigger a roll of the active NN", ioe); } }
