YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/ea458a38 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/ea458a38 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/ea458a38 Branch: refs/heads/YARN-2928 Commit: ea458a383b607e408c0be433f5e1c15d08bd680b Parents: 233f106 Author: Jian He <[email protected]> Authored: Mon Apr 20 10:38:27 2015 -0700 Committer: Zhijie Shen <[email protected]> Committed: Tue Apr 21 16:16:54 2015 -0700 ---------------------------------------------------------------------- hadoop-yarn-project/CHANGES.txt | 3 +++ .../yarn/client/api/impl/ContainerManagementProtocolProxy.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/ea458a38/hadoop-yarn-project/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 0f9eef6..fe57d64 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -303,6 +303,9 @@ Release 2.7.1 - UNRELEASED YARN-3487. CapacityScheduler scheduler lock obtained unnecessarily when calling getQueue (Jason Lowe via wangda) + YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf + without making a copy. (Jason Lowe via jianhe) + Release 2.7.0 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/ea458a38/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java index eaf048d..94ebf0d 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/ContainerManagementProtocolProxy.java @@ -67,7 +67,7 @@ public class ContainerManagementProtocolProxy { public ContainerManagementProtocolProxy(Configuration conf, NMTokenCache nmTokenCache) { - this.conf = conf; + this.conf = new Configuration(conf); this.nmTokenCache = nmTokenCache; maxConnectedNMs = @@ -88,7 +88,7 @@ public class ContainerManagementProtocolProxy { cmProxy = Collections.emptyMap(); // Connections are not being cached so ensure connections close quickly // to avoid creating thousands of RPC client threads on large clusters. - conf.setInt( + this.conf.setInt( CommonConfigurationKeysPublic.IPC_CLIENT_CONNECTION_MAXIDLETIME_KEY, 0); }
