Repository: hadoop Updated Branches: refs/heads/branch-2 f99744b7a -> c8dc11394
HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from RollingWindowManager. Contributed by Brahma Reddy Battula. (cherry picked from commit b61b48999530851da177db2e8998858ffc01f77e) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/c8dc1139 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/c8dc1139 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/c8dc1139 Branch: refs/heads/branch-2 Commit: c8dc1139439224d0454659b45efa48b4a7847347 Parents: f99744b Author: Xiaoyu Yao <[email protected]> Authored: Sat Jun 6 18:47:45 2015 -0700 Committer: Xiaoyu Yao <[email protected]> Committed: Sat Jun 6 18:48:52 2015 -0700 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../server/namenode/top/window/RollingWindowManager.java | 8 +++----- 2 files changed, 6 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/c8dc1139/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 9e253bb..aa5dd39 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -266,6 +266,9 @@ Release 2.8.0 - UNRELEASED HDFS-8432. Introduce a minimum compatible layout version to allow downgrade in more rolling upgrade use cases. (cnauroth) + HDFS-8116. Cleanup uncessary if LOG.isDebugEnabled() from + RollingWindowManager. (Brahma Reddy Battula via xyao) + OPTIMIZATIONS HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than http://git-wip-us.apache.org/repos/asf/hadoop/blob/c8dc1139/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java index 4759cc8..63438ff 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java @@ -187,11 +187,9 @@ public class RollingWindowManager { */ public TopWindow snapshot(long time) { TopWindow window = new TopWindow(windowLenMs); - if (LOG.isDebugEnabled()) { - Set<String> metricNames = metricMap.keySet(); - LOG.debug("iterating in reported metrics, size={} values={}", - metricNames.size(), metricNames); - } + Set<String> metricNames = metricMap.keySet(); + LOG.debug("iterating in reported metrics, size={} values={}", + metricNames.size(), metricNames); for (Map.Entry<String, RollingWindowMap> entry : metricMap.entrySet()) { String metricName = entry.getKey(); RollingWindowMap rollingWindows = entry.getValue();
