Repository: hadoop Updated Branches: refs/heads/trunk 3b85bd7c3 -> 30e2f836a
HADOOP-11098. [JDK8] Max Non Heap Memory default changed between JDK7 and 8. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/30e2f836 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/30e2f836 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/30e2f836 Branch: refs/heads/trunk Commit: 30e2f836a26490a24c7ddea754dd19f95b24bbc8 Parents: 3b85bd7 Author: Tsuyoshi Ozawa <[email protected]> Authored: Mon Oct 5 08:15:06 2015 +0900 Committer: Tsuyoshi Ozawa <[email protected]> Committed: Mon Oct 5 08:15:06 2015 +0900 ---------------------------------------------------------------------- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../apache/hadoop/metrics2/source/JvmMetrics.java | 15 +++++++++++++-- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html | 4 ++-- 4 files changed, 21 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/30e2f836/hadoop-common-project/hadoop-common/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index a672962..e725272 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -1113,6 +1113,9 @@ Release 2.8.0 - UNRELEASED HADOOP-8437. getLocalPathForWrite should throw IOException for invalid paths. (Brahma Reddy Battula via zxu) + HADOOP-11098. [JDK8] Max Non Heap Memory default changed between JDK7 + and 8. (ozawa) + OPTIMIZATIONS HADOOP-12051. ProtobufRpcEngine.invoke() should use Exception.toString() http://git-wip-us.apache.org/repos/asf/hadoop/blob/30e2f836/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java index c62caf3..164aa93 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java @@ -60,6 +60,7 @@ public class JvmMetrics implements MetricsSource { } static final float M = 1024*1024; + static public final float MEMORY_MAX_UNLIMITED_MB = -1; final MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean(); final List<GarbageCollectorMXBean> gcBeans = @@ -106,13 +107,23 @@ public class JvmMetrics implements MetricsSource { Runtime runtime = Runtime.getRuntime(); rb.addGauge(MemNonHeapUsedM, memNonHeap.getUsed() / M) .addGauge(MemNonHeapCommittedM, memNonHeap.getCommitted() / M) - .addGauge(MemNonHeapMaxM, memNonHeap.getMax() / M) + .addGauge(MemNonHeapMaxM, calculateMaxMemoryUsage(memNonHeap)) .addGauge(MemHeapUsedM, memHeap.getUsed() / M) .addGauge(MemHeapCommittedM, memHeap.getCommitted() / M) - .addGauge(MemHeapMaxM, memHeap.getMax() / M) + .addGauge(MemHeapMaxM, calculateMaxMemoryUsage(memHeap)) .addGauge(MemMaxM, runtime.maxMemory() / M); } + private float calculateMaxMemoryUsage(MemoryUsage memHeap) { + long max = memHeap.getMax() ; + + if (max == -1) { + return MEMORY_MAX_UNLIMITED_MB; + } + + return max / M; + } + private void getGcUsage(MetricsRecordBuilder rb) { long count = 0; long timeMillis = 0; http://git-wip-us.apache.org/repos/asf/hadoop/blob/30e2f836/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 0957680..ec7e084 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -1486,6 +1486,9 @@ Release 2.8.0 - UNRELEASED HDFS-9193. Fix incorrect references the usages of the DN in dfshealth.js. (Chang Li via wheat9) + HADOOP-11098. [JDK8] Max Non Heap Memory default changed between JDK7 + and 8 (ozawa). + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/30e2f836/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html index ad3ac0d..4460f97 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html @@ -150,11 +150,11 @@ {/fs} </p> {#mem.HeapMemoryUsage} -<p>Heap Memory used {used|fmt_bytes} of {committed|fmt_bytes} Heap Memory. Max Heap Memory is {max|fmt_bytes}. </p> +<p>Heap Memory used {used|fmt_bytes} of {committed|fmt_bytes} Heap Memory. Max Heap Memory is {@eq key=max value="-1" type="number"}<unbonded>{:else}{max|fmt_bytes}{/eq}.</p> {/mem.HeapMemoryUsage} {#mem.NonHeapMemoryUsage} -<p>Non Heap Memory used {used|fmt_bytes} of {committed|fmt_bytes} Commited Non Heap Memory. Max Non Heap Memory is {max|fmt_bytes}. </p> +<p>Non Heap Memory used {used|fmt_bytes} of {committed|fmt_bytes} Commited Non Heap Memory. Max Non Heap Memory is {@eq key=max value="-1" type="number"}<unbonded>{:else}{max|fmt_bytes}{/eq}.</p> {/mem.NonHeapMemoryUsage} {#nn}
