Repository: hadoop Updated Branches: refs/heads/branch-2 28edc7b12 -> 5e2a44a7f
HDFS-9221. HdfsServerConstants#ReplicaState#getState should avoid calling values() since it creates a temporary array. (Staffan Friberg via yliu) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/5e2a44a7 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/5e2a44a7 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/5e2a44a7 Branch: refs/heads/branch-2 Commit: 5e2a44a7fef75e76d95fe4259c736ec4a7978fce Parents: 28edc7b Author: yliu <[email protected]> Authored: Mon Oct 12 14:30:01 2015 +0800 Committer: yliu <[email protected]> Committed: Mon Oct 12 14:30:01 2015 +0800 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../apache/hadoop/hdfs/server/common/HdfsServerConstants.java | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/5e2a44a7/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 622e8dd..8bf2285 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -682,6 +682,9 @@ Release 2.8.0 - UNRELEASED HDFS-9110. Use Files.walkFileTree in NNUpgradeUtil#doPreUpgrade for better efficiency. (Charlie Helin via wang) + HDFS-9221. HdfsServerConstants#ReplicaState#getState should avoid calling + values() since it creates a temporary array. (Staffan Friberg via yliu) + OPTIMIZATIONS HDFS-8026. Trace FSOutputSummer#writeChecksumChunks rather than http://git-wip-us.apache.org/repos/asf/hadoop/blob/5e2a44a7/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java index ef2027e..e447d3a 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java @@ -292,6 +292,8 @@ public interface HdfsServerConstants { /** Temporary replica: created for replication and relocation only. */ TEMPORARY(4); + private static final ReplicaState[] cachedValues = ReplicaState.values(); + private final int value; ReplicaState(int v) { @@ -303,12 +305,12 @@ public interface HdfsServerConstants { } public static ReplicaState getState(int v) { - return ReplicaState.values()[v]; + return cachedValues[v]; } /** Read from in */ public static ReplicaState read(DataInput in) throws IOException { - return values()[in.readByte()]; + return cachedValues[in.readByte()]; } /** Write to out */
