HDFS-9401. Fix findbugs warnings in BlockRecoveryWorker. Contributed by Brahma Reddy Battula.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/2fda45b9 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/2fda45b9 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/2fda45b9 Branch: refs/heads/yarn-2877 Commit: 2fda45b9dc9c0bf9bb1380134c80836e89d50471 Parents: 94a1833 Author: Walter Su <waltersu4...@apache.org> Authored: Tue Nov 10 14:48:08 2015 +0800 Committer: Walter Su <waltersu4...@apache.org> Committed: Tue Nov 10 14:48:08 2015 +0800 ---------------------------------------------------------------------- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt | 3 +++ .../hadoop-hdfs/dev-support/findbugsExcludeFile.xml | 7 ------- .../hadoop/hdfs/server/datanode/BlockRecoveryWorker.java | 3 ++- 3 files changed, 5 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/2fda45b9/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index ae0cfff..8625ecf 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -2282,6 +2282,9 @@ Release 2.8.0 - UNRELEASED HDFS-9249. NPE is thrown if an IOException is thrown in NameNode constructor. (Wei-Chiu Chuang via Yongjun Zhang) + HDFS-9401. Fix findbugs warnings in BlockRecoveryWorker. + (Brahma Reddy Battula via waltersu4549) + Release 2.7.3 - UNRELEASED INCOMPATIBLE CHANGES http://git-wip-us.apache.org/repos/asf/hadoop/blob/2fda45b9/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml index c88c4c4..3ae8b59 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml +++ b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml @@ -124,13 +124,6 @@ <Bug pattern="DM_EXIT" /> </Match> - <!-- Don't complain about recoverBlock equality check --> - <Match> - <Class name="org.apache.hadoop.hdfs.server.datanode.DataNode" /> - <Method name="recoverBlock" /> - <Bug pattern="EC_UNRELATED_TYPES" /> - </Match> - <!-- More complex cleanup logic confuses findbugs --> <Match> <Class name="org.apache.hadoop.hdfs.qjournal.server.Journal" /> http://git-wip-us.apache.org/repos/asf/hadoop/blob/2fda45b9/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java index 9bd8703..c5bf1fa 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java @@ -112,7 +112,8 @@ public class BlockRecoveryWorker { // - Original state is RWR or better for(DatanodeID id : locs) { try { - DatanodeID bpReg =datanode.getBPOfferService(bpid).bpRegistration; + DatanodeID bpReg = new DatanodeID( + datanode.getBPOfferService(bpid).bpRegistration); InterDatanodeProtocol proxyDN = bpReg.equals(id)? datanode: DataNode.createInterDataNodeProtocolProxy(id, conf, dnConf.socketTimeout, dnConf.connectToDnViaHostname);
