Repository: hadoop Updated Branches: refs/heads/branch-2 1f96baf4a -> 7aaf82d46
YARN-4366. Fix Lint Warnings in YARN Common (templedf via rkanter) (cherry picked from commit bf6f4a3b980a07d0b268eeb984a649a362877734) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/7aaf82d4 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/7aaf82d4 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/7aaf82d4 Branch: refs/heads/branch-2 Commit: 7aaf82d4698d43d52a325671f10d2a1d7d87ba68 Parents: 1f96baf Author: Robert Kanter <[email protected]> Authored: Tue Jul 12 15:12:25 2016 -0700 Committer: Robert Kanter <[email protected]> Committed: Tue Jul 12 15:13:00 2016 -0700 ---------------------------------------------------------------------- .../yarn/factory/providers/RpcFactoryProvider.java | 13 ++++--------- .../java/org/apache/hadoop/yarn/webapp/Router.java | 2 +- 2 files changed, 5 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/7aaf82d4/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java index 42067e8..027dc84 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factory/providers/RpcFactoryProvider.java @@ -59,16 +59,11 @@ public class RpcFactoryProvider { private static Object getFactoryClassInstance(String factoryClassName) { try { Class<?> clazz = Class.forName(factoryClassName); - Method method = clazz.getMethod("get", null); + Method method = clazz.getMethod("get"); method.setAccessible(true); - return method.invoke(null, null); - } catch (ClassNotFoundException e) { - throw new YarnRuntimeException(e); - } catch (NoSuchMethodException e) { - throw new YarnRuntimeException(e); - } catch (InvocationTargetException e) { - throw new YarnRuntimeException(e); - } catch (IllegalAccessException e) { + return method.invoke(null); + } catch (ClassNotFoundException | NoSuchMethodException | + InvocationTargetException | IllegalAccessException e) { throw new YarnRuntimeException(e); } } http://git-wip-us.apache.org/repos/asf/hadoop/blob/7aaf82d4/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java index cf78818..c46b50e 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Router.java @@ -97,7 +97,7 @@ class Router { // Note: this does not distinguish methods with the same signature // but different return types. // TODO: We may want to deal with methods that take parameters in the future - Method method = cls.getMethod(action, null); + Method method = cls.getMethod(action); Dest dest = routes.get(path); if (dest == null) { method.setAccessible(true); // avoid any runtime checks --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
