HADOOP-13467. Shell#getSignalKillCommand should use the bash builtin on Linux. (Arpit Agarwal)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/365a2709 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/365a2709 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/365a2709 Branch: refs/heads/branch-2 Commit: 365a27099c5f2ea273368df7e899650d10fc5c99 Parents: 3b2554f Author: Arpit Agarwal <[email protected]> Authored: Thu Aug 4 10:07:53 2016 -0700 Committer: Arpit Agarwal <[email protected]> Committed: Thu Aug 4 10:08:23 2016 -0700 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/util/Shell.java | 11 ++++++++--- .../src/test/java/org/apache/hadoop/util/TestShell.java | 12 ++++++++---- 2 files changed, 16 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/365a2709/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java index 3007d32..0311a1e 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java @@ -311,11 +311,16 @@ public abstract class Shell { } } + // Use the bash-builtin instead of the Unix kill command (usually + // /bin/kill) as the bash-builtin supports "--" in all Hadoop supported + // OSes. + final String quotedPid = bashQuote(pid); if (isSetsidAvailable) { - // Use the shell-builtin as it support "--" in all Hadoop supported OSes - return new String[] {"kill", "-" + code, "--", "-" + pid}; + return new String[] { "bash", "-c", "kill -" + code + " -- -" + + quotedPid }; } else { - return new String[] {"kill", "-" + code, pid }; + return new String[] { "bash", "-c", "kill -" + code + " " + + quotedPid }; } } http://git-wip-us.apache.org/repos/asf/hadoop/blob/365a2709/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java index c0491fac..3ef6fb1 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestShell.java @@ -240,9 +240,11 @@ public class TestShell extends Assert { expectedCommand = new String[]{getWinUtilsPath(), "task", "isAlive", anyPid }; } else if (Shell.isSetsidAvailable) { - expectedCommand = new String[] {"kill", "-0", "--", "-" + anyPid }; + expectedCommand = new String[] { "bash", "-c", "kill -0 -- -'" + + anyPid + "'"}; } else { - expectedCommand = new String[] {"kill", "-0", anyPid }; + expectedCommand = new String[] {"bash", "-c", "kill -0 '" + anyPid + + "'" }; } Assert.assertArrayEquals(expectedCommand, checkProcessAliveCommand); } @@ -260,9 +262,11 @@ public class TestShell extends Assert { expectedCommand = new String[]{getWinUtilsPath(), "task", "kill", anyPid }; } else if (Shell.isSetsidAvailable) { - expectedCommand = new String[] {"kill", "-9", "--", "-" + anyPid }; + expectedCommand = new String[] { "bash", "-c", "kill -9 -- -'" + anyPid + + "'"}; } else { - expectedCommand = new String[] {"kill", "-9", anyPid }; + expectedCommand = new String[]{ "bash", "-c", "kill -9 '" + anyPid + + "'"}; } Assert.assertArrayEquals(expectedCommand, checkProcessAliveCommand); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
