Repository: hadoop Updated Branches: refs/heads/YARN-3368 9b1532903 -> 91efda9e0 (forced update)
HDFS-10772. Reduce byte/string conversions for get listing. Contributed by Daryn Sharp. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/a1f32937 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/a1f32937 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/a1f32937 Branch: refs/heads/YARN-3368 Commit: a1f3293762dddb0ca953d1145f5b53d9086b25b8 Parents: 3476156 Author: Kihwal Lee <[email protected]> Authored: Wed Aug 24 15:21:08 2016 -0500 Committer: Kihwal Lee <[email protected]> Committed: Wed Aug 24 15:21:08 2016 -0500 ---------------------------------------------------------------------- .../server/namenode/FSDirStatAndListingOp.java | 26 +++++++++++--------- 1 file changed, 15 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/a1f32937/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java index 8a9393e..5072d68 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java @@ -24,6 +24,7 @@ import org.apache.hadoop.fs.ContentSummary; import org.apache.hadoop.fs.DirectoryListingStartAfterNotFoundException; import org.apache.hadoop.fs.FileEncryptionInfo; import org.apache.hadoop.fs.InvalidPathException; +import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.permission.FsAction; import org.apache.hadoop.fs.permission.FsPermission; import org.apache.hadoop.fs.QuotaUsage; @@ -52,7 +53,6 @@ import static org.apache.hadoop.util.Time.now; class FSDirStatAndListingOp { static DirectoryListing getListingInt(FSDirectory fsd, final String srcArg, byte[] startAfter, boolean needLocation) throws IOException { - final String startAfterString = DFSUtil.bytes2String(startAfter); String src = null; final INodesInPath iip; @@ -65,16 +65,20 @@ class FSDirStatAndListingOp { iip = fsd.getINodesInPath(src, true); } - // Get file name when startAfter is an INodePath - if (FSDirectory.isReservedName(startAfterString)) { - try { - String tmp = FSDirectory.resolvePath(startAfterString, fsd); - byte[][] regularPath = INode.getPathComponents(tmp); - startAfter = regularPath[regularPath.length - 1]; - } catch (IOException e) { - // Possibly the inode is deleted - throw new DirectoryListingStartAfterNotFoundException( - "Can't find startAfter " + startAfterString); + // Get file name when startAfter is an INodePath. This is not the + // common case so avoid any unnecessary processing unless required. + if (startAfter.length > 0 && startAfter[0] == Path.SEPARATOR_CHAR) { + final String startAfterString = DFSUtil.bytes2String(startAfter); + if (FSDirectory.isReservedName(startAfterString)) { + try { + byte[][] components = INode.getPathComponents(startAfterString); + components = FSDirectory.resolveComponents(components, fsd); + startAfter = components[components.length - 1]; + } catch (IOException e) { + // Possibly the inode is deleted + throw new DirectoryListingStartAfterNotFoundException( + "Can't find startAfter " + startAfterString); + } } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
