YARN-6381. FSAppAttempt has several variables that should be final (Contributed by Ameet Zaveri via Daniel Templeton)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/8bbd3357 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/8bbd3357 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/8bbd3357 Branch: refs/heads/HDFS-10467 Commit: 8bbd335710476efd1d49c955dbad5495a7d62e00 Parents: 546d533 Author: Daniel Templeton <[email protected]> Authored: Wed Apr 5 16:06:00 2017 -0700 Committer: Inigo <[email protected]> Committed: Thu Apr 6 18:58:23 2017 -0700 ---------------------------------------------------------------------- .../resourcemanager/scheduler/fair/FSAppAttempt.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/8bbd3357/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java index ccfcffb..e0dfb73 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java @@ -74,11 +74,11 @@ public class FSAppAttempt extends SchedulerApplicationAttempt private static final DefaultResourceCalculator RESOURCE_CALCULATOR = new DefaultResourceCalculator(); - private long startTime; - private Priority appPriority; - private ResourceWeights resourceWeights; + private final long startTime; + private final Priority appPriority; + private final ResourceWeights resourceWeights; private Resource demand = Resources.createResource(0); - private FairScheduler scheduler; + private final FairScheduler scheduler; private FSQueue fsQueue; private Resource fairShare = Resources.createResource(0, 0); @@ -96,9 +96,9 @@ public class FSAppAttempt extends SchedulerApplicationAttempt // Used to record node reservation by an app. // Key = RackName, Value = Set of Nodes reserved by app on rack - private Map<String, Set<String>> reservations = new HashMap<>(); + private final Map<String, Set<String>> reservations = new HashMap<>(); - private List<FSSchedulerNode> blacklistNodeIds = new ArrayList<>(); + private final List<FSSchedulerNode> blacklistNodeIds = new ArrayList<>(); /** * Delay scheduling: We often want to prioritize scheduling of node-local * containers over rack-local or off-switch containers. To achieve this --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
