HDFS-11943. [Erasure coding] Warn log frequently print to screen in doEncode/doDecode functions. Contributed by liaoyuxiangqin
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/379f19a2 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/379f19a2 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/379f19a2 Branch: refs/heads/HADOOP-13345 Commit: 379f19a2c768ac3cf668ad28ce6419ca56a01b07 Parents: a594f96 Author: Kai Zheng <[email protected]> Authored: Mon Jun 26 16:26:09 2017 +0800 Committer: Kai Zheng <[email protected]> Committed: Mon Jun 26 16:26:09 2017 +0800 ---------------------------------------------------------------------- .../io/erasurecode/rawcoder/AbstractNativeRawDecoder.java | 8 +++++++- .../io/erasurecode/rawcoder/AbstractNativeRawEncoder.java | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/379f19a2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawDecoder.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawDecoder.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawDecoder.java index 55edb64..d6aa8bd 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawDecoder.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawDecoder.java @@ -19,6 +19,7 @@ package org.apache.hadoop.io.erasurecode.rawcoder; import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.io.erasurecode.ErasureCoderOptions; +import org.apache.hadoop.util.PerformanceAdvisory; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -66,7 +67,7 @@ abstract class AbstractNativeRawDecoder extends RawErasureDecoder { @Override protected void doDecode(ByteArrayDecodingState decodingState) { - LOG.warn("convertToByteBufferState is invoked, " + + PerformanceAdvisory.LOG.debug("convertToByteBufferState is invoked, " + "not efficiently. Please use direct ByteBuffer inputs/outputs"); ByteBufferDecodingState bbdState = decodingState.convertToByteBufferState(); @@ -78,6 +79,11 @@ abstract class AbstractNativeRawDecoder extends RawErasureDecoder { } } + @Override + public boolean preferDirectBuffer() { + return true; + } + // To link with the underlying data structure in the native layer. // No get/set as only used by native codes. private long nativeCoder; http://git-wip-us.apache.org/repos/asf/hadoop/blob/379f19a2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawEncoder.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawEncoder.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawEncoder.java index b2c7016..21805fe 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawEncoder.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/AbstractNativeRawEncoder.java @@ -19,6 +19,7 @@ package org.apache.hadoop.io.erasurecode.rawcoder; import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.io.erasurecode.ErasureCoderOptions; +import org.apache.hadoop.util.PerformanceAdvisory; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -63,7 +64,7 @@ abstract class AbstractNativeRawEncoder extends RawErasureEncoder { @Override protected void doEncode(ByteArrayEncodingState encodingState) { - LOG.warn("convertToByteBufferState is invoked, " + + PerformanceAdvisory.LOG.debug("convertToByteBufferState is invoked, " + "not efficiently. Please use direct ByteBuffer inputs/outputs"); ByteBufferEncodingState bbeState = encodingState.convertToByteBufferState(); @@ -75,6 +76,11 @@ abstract class AbstractNativeRawEncoder extends RawErasureEncoder { } } + @Override + public boolean preferDirectBuffer() { + return true; + } + // To link with the underlying data structure in the native layer. // No get/set as only used by native codes. private long nativeCoder; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
