Repository: hadoop Updated Branches: refs/heads/trunk 3a0b84d9c -> f9139ac8f
YARN-6872. [Addendum patch] Ensure apps could run given NodeLabels are disabled post RM switchover/restart. Contributed by Sunil G Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/f9139ac8 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/f9139ac8 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/f9139ac8 Branch: refs/heads/trunk Commit: f9139ac8f60184a82a8bb315237bea04bdb98ec8 Parents: 3a0b84d Author: Jian He <[email protected]> Authored: Wed Aug 2 00:03:25 2017 -0700 Committer: Jian He <[email protected]> Committed: Wed Aug 2 00:03:25 2017 -0700 ---------------------------------------------------------------------- .../scheduler/AbstractYarnScheduler.java | 18 ++++-------------- .../scheduler/AppSchedulingInfo.java | 6 +++--- .../scheduler/SchedulerApplicationAttempt.java | 2 +- 3 files changed, 8 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/f9139ac8/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java index b40ce40..d506f4d 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java @@ -519,20 +519,10 @@ public abstract class AbstractYarnScheduler container.setVersion(status.getVersion()); ApplicationAttemptId attemptId = container.getId().getApplicationAttemptId(); - String labelExpression = status.getNodeLabelExpression(); - // If NodeLabel is disabled but recovered container has label expression - // its better to suppress that and considered as default label. - if (!status.getNodeLabelExpression().isEmpty() && !YarnConfiguration - .areNodeLabelsEnabled(rmContext.getYarnConfiguration())) { - labelExpression = RMNodeLabelsManager.NO_LABEL; - } - - RMContainer rmContainer = - new RMContainerImpl(container, - SchedulerRequestKey.extractFrom(container), attemptId, - node.getNodeID(), applications.get( - attemptId.getApplicationId()).getUser(), rmContext, - status.getCreationTime(), labelExpression); + RMContainer rmContainer = new RMContainerImpl(container, + SchedulerRequestKey.extractFrom(container), attemptId, node.getNodeID(), + applications.get(attemptId.getApplicationId()).getUser(), rmContext, + status.getCreationTime(), status.getNodeLabelExpression()); return rmContainer; } http://git-wip-us.apache.org/repos/asf/hadoop/blob/f9139ac8/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java index 851c9f5..8acf7d5 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java @@ -524,7 +524,7 @@ public class AppSchedulingInfo { this.placesBlacklistedByApp = appInfo.getBlackList(); } - public void recoverContainer(RMContainer rmContainer) { + public void recoverContainer(RMContainer rmContainer, String partition) { try { this.writeLock.lock(); QueueMetrics metrics = queue.getMetrics(); @@ -540,8 +540,8 @@ public class AppSchedulingInfo { return; } - metrics.allocateResources(rmContainer.getNodeLabelExpression(), - user, 1, rmContainer.getAllocatedResource(), false); + metrics.allocateResources(partition, user, 1, + rmContainer.getAllocatedResource(), false); } finally { this.writeLock.unlock(); } http://git-wip-us.apache.org/repos/asf/hadoop/blob/f9139ac8/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java index 4b0bf91..8b2f9db 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java @@ -1103,7 +1103,7 @@ public class SchedulerApplicationAttempt implements SchedulableEntity { try { writeLock.lock(); // recover app scheduling info - appSchedulingInfo.recoverContainer(rmContainer); + appSchedulingInfo.recoverContainer(rmContainer, node.getPartition()); if (rmContainer.getState().equals(RMContainerState.COMPLETED)) { return; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
