HDFS-12530. Processor argument in Offline Image Viewer should be case insensitive. Contributed by Hanisha Koneru.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/09290659 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/09290659 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/09290659 Branch: refs/heads/branch-2 Commit: 09290659e72b9309b4f0572a9ee7b02627388ffe Parents: b94acb6 Author: Arpit Agarwal <a...@apache.org> Authored: Fri Sep 22 09:47:57 2017 -0700 Committer: Arpit Agarwal <a...@apache.org> Committed: Fri Sep 22 09:48:10 2017 -0700 ---------------------------------------------------------------------- .../tools/offlineImageViewer/OfflineImageViewerPB.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/09290659/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java index 38f7cf0..69e4bd2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java @@ -33,6 +33,7 @@ import org.apache.commons.logging.LogFactory; import org.apache.hadoop.classification.InterfaceAudience; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.net.NetUtils; +import org.apache.hadoop.util.StringUtils; /** * OfflineImageViewerPB to dump the contents of an Hadoop image file to XML or @@ -174,8 +175,8 @@ public class OfflineImageViewerPB { Configuration conf = new Configuration(); try (PrintStream out = outputFile.equals("-") ? System.out : new PrintStream(outputFile, "UTF-8")) { - switch (processor) { - case "FileDistribution": + switch (StringUtils.toUpperCase(processor)) { + case "FILEDISTRIBUTION": long maxSize = Long.parseLong(cmd.getOptionValue("maxSize", "0")); int step = Integer.parseInt(cmd.getOptionValue("step", "0")); boolean formatOutput = cmd.hasOption("format"); @@ -186,7 +187,7 @@ public class OfflineImageViewerPB { new PBImageXmlWriter(conf, out).visit(new RandomAccessFile(inputFile, "r")); break; - case "ReverseXML": + case "REVERSEXML": try { OfflineImageReconstructor.run(inputFile, outputFile); } catch (Exception e) { @@ -196,14 +197,14 @@ public class OfflineImageViewerPB { System.exit(1); } break; - case "Web": + case "WEB": String addr = cmd.getOptionValue("addr", "localhost:5978"); try (WebImageViewer viewer = new WebImageViewer(NetUtils.createSocketAddr(addr))) { viewer.start(inputFile); } break; - case "Delimited": + case "DELIMITED": try (PBImageDelimitedTextWriter writer = new PBImageDelimitedTextWriter(out, delimiter, tempPath)) { writer.visit(new RandomAccessFile(inputFile, "r")); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
