HADOOP-15067. GC time percentage reported in JvmMetrics should be a gauge, not counter. Contributed by Misha Dmitriev.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/d162252d Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/d162252d Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/d162252d Branch: refs/heads/YARN-5881 Commit: d162252d7a7223631ff66ba0210953296407e55f Parents: b46ca7e Author: Xiao Chen <x...@apache.org> Authored: Thu Nov 23 09:00:59 2017 -0800 Committer: Xiao Chen <x...@apache.org> Committed: Thu Nov 23 09:01:28 2017 -0800 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java | 2 +- .../java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/d162252d/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java index 8c3375f..5f9afdd 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java @@ -188,7 +188,7 @@ public class JvmMetrics implements MetricsSource { } if (gcTimeMonitor != null) { - rb.addCounter(GcTimePercentage, + rb.addGauge(GcTimePercentage, gcTimeMonitor.getLatestGcData().getGcTimePercentage()); } } http://git-wip-us.apache.org/repos/asf/hadoop/blob/d162252d/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java index 5320b6e..aa1b009 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/source/TestJvmMetrics.java @@ -101,7 +101,7 @@ public class TestJvmMetrics { verify(rb).tag(SessionId, "test"); for (JvmMetricsInfo info : JvmMetricsInfo.values()) { if (info.name().equals("GcTimePercentage")) { - verify(rb).addCounter(eq(info), anyInt()); + verify(rb).addGauge(eq(info), anyInt()); } } } --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
