YARN-7591. NPE in async-scheduling mode of CapacityScheduler. (Tao Yang via wangda)
Change-Id: I46689e530550ee0a6ac7a29786aab2cc1bdf314f Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/adca1a72 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/adca1a72 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/adca1a72 Branch: refs/heads/trunk Commit: adca1a72e4eca2ea634551e9fb8e9b878c36cb5c Parents: a8316df Author: Wangda Tan <[email protected]> Authored: Fri Dec 8 15:17:02 2017 -0800 Committer: Wangda Tan <[email protected]> Committed: Fri Dec 8 15:17:02 2017 -0800 ---------------------------------------------------------------------- .../scheduler/capacity/CapacityScheduler.java | 4 ++++ .../scheduler/capacity/LeafQueue.java | 21 +++++++++++++++++++- .../scheduler/common/fica/FiCaSchedulerApp.java | 5 +++++ 3 files changed, 29 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/adca1a72/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java index a5efd9f..8de3631 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java @@ -1301,6 +1301,10 @@ public class CapacityScheduler extends if (reservedContainer != null) { FiCaSchedulerApp reservedApplication = getCurrentAttemptForContainer( reservedContainer.getContainerId()); + if (reservedApplication == null) { + LOG.error("Trying to schedule for a finished app, please double check."); + return null; + } // Try to fulfill the reservation LOG.info( http://git-wip-us.apache.org/repos/asf/hadoop/blob/adca1a72/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java index 86fcbc9..ac1a26c 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java @@ -1201,7 +1201,14 @@ public class LeafQueue extends AbstractCSQueue { allocation.getSchedulingMode(), null); // Deduct resources that we can release - Resource usedResource = Resources.clone(getUser(username).getUsed(p)); + User user = getUser(username); + if (user == null) { + if (LOG.isDebugEnabled()) { + LOG.debug("User " + username + " has been removed!"); + } + return false; + } + Resource usedResource = Resources.clone(user.getUsed(p)); Resources.subtractFrom(usedResource, request.getTotalReleasedResource()); @@ -1406,6 +1413,12 @@ public class LeafQueue extends AbstractCSQueue { SchedulingMode schedulingMode, Resource userLimit) { String user = application.getUser(); User queueUser = getUser(user); + if (queueUser == null) { + if (LOG.isDebugEnabled()) { + LOG.debug("User " + user + " has been removed!"); + } + return Resources.none(); + } // Compute user limit respect requested labels, // TODO, need consider headroom respect labels also @@ -1500,6 +1513,12 @@ public class LeafQueue extends AbstractCSQueue { try { readLock.lock(); User user = getUser(userName); + if (user == null) { + if (LOG.isDebugEnabled()) { + LOG.debug("User " + userName + " has been removed!"); + } + return false; + } currentResourceLimits.setAmountNeededUnreserve(Resources.none()); http://git-wip-us.apache.org/repos/asf/hadoop/blob/adca1a72/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java index a4e0096..776a7e9 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/FiCaSchedulerApp.java @@ -322,6 +322,11 @@ public class FiCaSchedulerApp extends SchedulerApplicationAttempt { RMContainer reservedContainerOnNode = schedulerContainer.getSchedulerNode().getReservedContainer(); if (reservedContainerOnNode != null) { + // adding NP check as this proposal could not be allocated from reserved + // container in async-scheduling mode + if (allocation.getAllocateFromReservedContainer() == null) { + return false; + } RMContainer fromReservedContainer = allocation.getAllocateFromReservedContainer().getRmContainer(); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
