HDFS-12237: libhdfs++: PROTOC_IS_COMPATIBLE check fails if protobuf library is built from source. Contributed by Anatoli Shein.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/eeb49d0c Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/eeb49d0c Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/eeb49d0c Branch: refs/heads/HDFS-8707 Commit: eeb49d0ca7149b4dd4204f952983cdc6f0471f00 Parents: 22ea06a Author: James Clampffer <[email protected]> Authored: Mon Aug 14 15:24:13 2017 -0400 Committer: James Clampffer <[email protected]> Committed: Thu Mar 22 17:19:47 2018 -0400 ---------------------------------------------------------------------- .../src/main/native/libhdfspp/CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/eeb49d0c/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt index 812af4b..2bcb49a 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt +++ b/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt @@ -65,6 +65,7 @@ endif (NOT THREAD_LOCAL_SUPPORTED) # Check if PROTOC library was compiled with the compatible compiler by trying # to compile some dummy code unset (PROTOC_IS_COMPATIBLE CACHE) +set (CMAKE_REQUIRED_INCLUDES ${PROTOBUF_INCLUDE_DIRS}) set (CMAKE_REQUIRED_LIBRARIES ${PROTOBUF_LIBRARY} ${PROTOBUF_PROTOC_LIBRARY}) check_cxx_source_compiles( "#include <google/protobuf/io/printer.h> @@ -77,8 +78,8 @@ check_cxx_source_compiles( }" PROTOC_IS_COMPATIBLE) if (NOT PROTOC_IS_COMPATIBLE) - message(FATAL_ERROR - "FATAL ERROR: the Protocol Buffers Library and the Libhdfs++ Library must both be compiled \ + message(WARNING + "WARNING: the Protocol Buffers Library and the Libhdfs++ Library must both be compiled \ with the same (or compatible) compiler. Normally only the same major versions of the same \ compiler are compatible with each other.") endif (NOT PROTOC_IS_COMPATIBLE) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
