HDFS-13318. RBF: Fix FindBugs in hadoop-hdfs-rbf. Contributed by Ekanth S. (cherry picked from commit 3d0ee8b80438bfbdf7e5af853b9044a63bd1352c) (cherry picked from commit 485348a337cd1923ab51784784f560f82c11af26)
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/05b9f0f5 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/05b9f0f5 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/05b9f0f5 Branch: refs/heads/branch-3.1.0 Commit: 05b9f0f5b7df45d26122a477518087faf9dde20f Parents: 3018aa6 Author: Inigo Goiri <[email protected]> Authored: Thu Mar 22 09:21:52 2018 -0700 Committer: Wangda Tan <[email protected]> Committed: Thu Mar 29 09:39:46 2018 -0700 ---------------------------------------------------------------------- .../server/federation/resolver/NamenodePriorityComparator.java | 5 ++++- .../hadoop/hdfs/server/federation/router/RemoteMethod.java | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/05b9f0f5/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/NamenodePriorityComparator.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/NamenodePriorityComparator.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/NamenodePriorityComparator.java index fe82f29..e9724a3 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/NamenodePriorityComparator.java +++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/NamenodePriorityComparator.java @@ -17,6 +17,7 @@ */ package org.apache.hadoop.hdfs.server.federation.resolver; +import java.io.Serializable; import java.util.Comparator; /** @@ -31,7 +32,9 @@ import java.util.Comparator; * breaker, newest has priority. Expired NNs are excluded. */ public class NamenodePriorityComparator - implements Comparator<FederationNamenodeContext> { + implements Comparator<FederationNamenodeContext>, Serializable { + + private static final long serialVersionUID = 2304924292036293331L; @Override public int compare(FederationNamenodeContext o1, http://git-wip-us.apache.org/repos/asf/hadoop/blob/05b9f0f5/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteMethod.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteMethod.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteMethod.java index cd57d45..7978105 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteMethod.java +++ b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteMethod.java @@ -76,7 +76,7 @@ public class RemoteMethod { } this.params = pParams; - this.types = pTypes; + this.types = Arrays.copyOf(pTypes, pTypes.length); this.methodName = method; } @@ -111,7 +111,7 @@ public class RemoteMethod { * @return An array of calling types. */ public Class<?>[] getTypes() { - return this.types; + return Arrays.copyOf(this.types, this.types.length); } /** --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
