HADOOP-15369. Avoid usage of ${project.version} in parent poms. Contributed by Elek Marton.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/ea95a335 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/ea95a335 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/ea95a335 Branch: refs/heads/HDFS-7240 Commit: ea95a335d0694cc52cbfdf1c6d1080af4eb92237 Parents: 896b473 Author: Xiaoyu Yao <x...@apache.org> Authored: Mon Apr 16 10:15:17 2018 -0700 Committer: Xiaoyu Yao <x...@apache.org> Committed: Mon Apr 16 10:15:37 2018 -0700 ---------------------------------------------------------------------- hadoop-project-dist/pom.xml | 4 +- hadoop-project/pom.xml | 158 +++++++++++++++++++-------------------- pom.xml | 27 +++++++ 3 files changed, 108 insertions(+), 81 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/ea95a335/hadoop-project-dist/pom.xml ---------------------------------------------------------------------- diff --git a/hadoop-project-dist/pom.xml b/hadoop-project-dist/pom.xml index e554be4..6dbc131 100644 --- a/hadoop-project-dist/pom.xml +++ b/hadoop-project-dist/pom.xml @@ -120,7 +120,7 @@ <docletArtifact> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-annotations</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </docletArtifact> </docletArtifacts> <useStandardDocletOptions>true</useStandardDocletOptions> @@ -393,7 +393,7 @@ <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-assemblies</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> </dependencies> <executions> http://git-wip-us.apache.org/repos/asf/hadoop/blob/ea95a335/hadoop-project/pom.xml ---------------------------------------------------------------------- diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml index c093927..02ea0ba 100644 --- a/hadoop-project/pom.xml +++ b/hadoop-project/pom.xml @@ -50,7 +50,7 @@ <kafka.version>0.8.2.1</kafka.version> - <hadoop.assemblies.version>${project.version}</hadoop.assemblies.version> + <hadoop.assemblies.version>3.2.0-SNAPSHOT</hadoop.assemblies.version> <commons-daemon.version>1.0.13</commons-daemon.version> <test.build.dir>${project.build.directory}/test-dir</test.build.dir> @@ -139,7 +139,7 @@ <frontend-maven-plugin.version>1.5</frontend-maven-plugin.version> <!-- the version of Hadoop declared in the version resources; can be overridden so that Hadoop 3.x can declare itself a 2.x artifact. --> - <declared.hadoop.version>${project.version}</declared.hadoop.version> + <declared.hadoop.version>${hadoop.version}</declared.hadoop.version> <swagger-annotations-version>1.5.4</swagger-annotations-version> <snakeyaml.version>1.16</snakeyaml.version> @@ -168,403 +168,403 @@ <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-assemblies</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-annotations</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-modules</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>pom</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-api</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-check-invariants</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>pom</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-check-test-invariants</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>pom</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-integration-tests</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-runtime</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client-minicluster</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-auth</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-auth</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-nfs</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-hdfs</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-hdfs-client</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-hdfs-rbf</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-hdfs</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-app</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-app</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-api</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-client</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-core</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-jobclient</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-shuffle</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>pom</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-web-proxy</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-tests</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-registry</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-nodemanager</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-resourcemanager</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-resourcemanager</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-applicationhistoryservice</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timelineservice</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timelineservice</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timelineservice-hbase-client</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timelineservice-hbase-common</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-applications-distributedshell</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timeline-pluginstorage</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-timeline-pluginstorage</artifactId> <type>test-jar</type> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-server-router</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-yarn-services-core</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-jobclient</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-client-hs</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-mapreduce-examples</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-gridmix</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-streaming</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-archives</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-archive-logs</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-distcp</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-distcp</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-datajoin</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-rumen</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-extras</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-client</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-minicluster</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-minikdc</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-openstack</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-azure</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-azure-datalake</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-aws</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-aliyun</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-kms</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-kms</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> <type>test-jar</type> </dependency> @@ -1111,12 +1111,12 @@ <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-sls</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-cloud-storage</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> <dependency> <groupId>com.google.code.findbugs</groupId> @@ -1515,7 +1515,7 @@ <plugin> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-maven-plugins</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </plugin> </plugins> </pluginManagement> @@ -1544,14 +1544,14 @@ <version>${maven-remote-resources-plugin.version}</version> <configuration> <resourceBundles> - <resourceBundle>org.apache.hadoop:hadoop-build-tools:${project.version}</resourceBundle> + <resourceBundle>org.apache.hadoop:hadoop-build-tools:${hadoop.version}</resourceBundle> </resourceBundles> </configuration> <dependencies> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-build-tools</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> </dependencies> <executions> @@ -1862,7 +1862,7 @@ <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>${hbase-server-artifactid}</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> </dependencies> </dependencyManagement> @@ -1889,7 +1889,7 @@ <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>${hbase-server-artifactid}</artifactId> - <version>${project.version}</version> + <version>${hadoop.version}</version> </dependency> </dependencies> </dependencyManagement> http://git-wip-us.apache.org/repos/asf/hadoop/blob/ea95a335/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 6cb2d4d..c761493 100644 --- a/pom.xml +++ b/pom.xml @@ -79,6 +79,9 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs </organization> <properties> + <!-- required as child projects with different version can't use ${project.version} --> + <hadoop.version>3.2.0-SNAPSHOT</hadoop.version> + <distMgmtSnapshotsId>apache.snapshots.https</distMgmtSnapshotsId> <distMgmtSnapshotsName>Apache Development Snapshot Repository</distMgmtSnapshotsName> <distMgmtSnapshotsUrl>https://repository.apache.org/content/repositories/snapshots</distMgmtSnapshotsUrl> @@ -420,6 +423,30 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs <artifactId>dependency-check-maven</artifactId> <version>${dependency-check-maven.version}</version> </plugin> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-enforcer-plugin</artifactId> + <version>${maven-enforcer-plugin.version}</version> + <executions> + <execution> + <id>enforce-property</id> + <goals> + <goal>enforce</goal> + </goals> + <configuration> + <rules> + <requireProperty> + <property>hadoop.version</property> + <message>You must set a hadoop.version to be the same as ${project.version}</message> + <regex>${project.version}</regex> + <regexMessage>The hadoop.version property should be set and should be ${project.version}.</regexMessage> + </requireProperty> + </rules> + <fail>true</fail> + </configuration> + </execution> + </executions> + </plugin> </plugins> </build> --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org