Repository: hadoop Updated Branches: refs/heads/trunk bcb57b1f8 -> 2d9e791a9
HDFS-12828. OIV ReverseXML Processor fails with escaped characters Signed-off-by: Akira Ajisaka <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/2d9e791a Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/2d9e791a Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/2d9e791a Branch: refs/heads/trunk Commit: 2d9e791a9073de9f65fef5407efd3a42894bc97f Parents: bcb57b1 Author: Erik Krogen <[email protected]> Authored: Wed Apr 18 14:38:23 2018 +0900 Committer: Akira Ajisaka <[email protected]> Committed: Wed Apr 18 14:38:23 2018 +0900 ---------------------------------------------------------------------- .../tools/offlineImageViewer/OfflineImageReconstructor.java | 4 ++-- .../hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/2d9e791a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java index d102375..7d0a492 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java @@ -385,8 +385,8 @@ class OfflineImageReconstructor { break; case XMLEvent.CHARACTERS: String val = XMLUtils. - unmangleXmlString(ev.asCharacters().getData(), true); - parent.setVal(val); + unmangleXmlString(ev.asCharacters().getData(), false); + parent.setVal(parent.getVal() + val); events.nextEvent(); break; case XMLEvent.ATTRIBUTE: http://git-wip-us.apache.org/repos/asf/hadoop/blob/2d9e791a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java ---------------------------------------------------------------------- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java index 7574cbf..b807804 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java @@ -194,10 +194,15 @@ public class TestOfflineImageViewer { dirCount++; writtenFiles.put(emptydir.toString(), hdfs.getFileStatus(emptydir)); - //Create a directory whose name should be escaped in XML + //Create directories whose name should be escaped in XML Path invalidXMLDir = new Path("/dirContainingInvalidXMLChar\u0000here"); hdfs.mkdirs(invalidXMLDir); dirCount++; + Path entityRefXMLDir = new Path("/dirContainingEntityRef&here"); + hdfs.mkdirs(entityRefXMLDir); + dirCount++; + writtenFiles.put(entityRefXMLDir.toString(), + hdfs.getFileStatus(entityRefXMLDir)); //Create a directory with sticky bits Path stickyBitDir = new Path("/stickyBit"); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
