HDFS-13586. Fsync fails on directories on Windows. Contributed by Lukas 
Majercack.

(cherry picked from commit 8783613696674aba4ae1739c6e8f48cda0d1c386)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/7336d012
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/7336d012
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/7336d012

Branch: refs/heads/branch-3.0
Commit: 7336d0123d825b6fa5943582d156559357fb201c
Parents: cdc16b3
Author: Inigo Goiri <inigo...@apache.org>
Authored: Thu May 17 19:26:44 2018 -0700
Committer: Inigo Goiri <inigo...@apache.org>
Committed: Thu May 17 19:27:51 2018 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/io/IOUtils.java           | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/7336d012/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
----------------------------------------------------------------------
diff --git 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
 
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
index 46ea1c8..a4339e6 100644
--- 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
+++ 
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
@@ -400,6 +400,13 @@ public class IOUtils {
           "File/Directory " + fileToSync.getAbsolutePath() + " does not 
exist");
     }
     boolean isDir = fileToSync.isDirectory();
+
+    // HDFS-13586, FileChannel.open fails with AccessDeniedException
+    // for any directory, ignore.
+    if (isDir && Shell.WINDOWS) {
+      return;
+    }
+
     // If the file is a directory we have to open read-only, for regular files
     // we must open r/w for the fsync to have an effect. See
     // http://blog.httrack.com/blog/2013/11/15/


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org

Reply via email to