YARN-8819. Fix findbugs warnings in YarnServiceUtils Signed-off-by: Akira Ajisaka <aajis...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/b85ee0d7 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/b85ee0d7 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/b85ee0d7 Branch: refs/heads/HEAD Commit: b85ee0d75d450f1c695cec1bebac627f66a97c98 Parents: cdf5d58 Author: Vidura Mudalige <vidura.mudal...@kohls.com> Authored: Thu Sep 27 21:40:13 2018 +0530 Committer: Akira Ajisaka <aajis...@apache.org> Committed: Sun Oct 7 00:53:53 2018 +0900 ---------------------------------------------------------------------- .../runtimes/yarnservice/YarnServiceUtils.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/b85ee0d7/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java index 26402da..d69840a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-submarine/src/main/java/org/apache/hadoop/yarn/submarine/runtimes/yarnservice/YarnServiceUtils.java @@ -115,15 +115,20 @@ public class YarnServiceUtils { private static String getComponentArrayJson(String componentName, int count, String endpointSuffix) { String component = "\\\"" + componentName + "\\\":"; - String array = "["; + StringBuilder array = new StringBuilder(); + array.append("["); for (int i = 0; i < count; i++) { - array = array + "\\\"" + componentName + "-" + i - + endpointSuffix + "\\\""; + array.append("\\\""); + array.append(componentName); + array.append("-"); + array.append(i); + array.append(endpointSuffix); + array.append("\\\""); if (i != count - 1) { - array = array + ","; + array.append(","); } } - array = array + "]"; - return component + array; + array.append("]"); + return component + array.toString(); } } --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
