Repository: hadoop
Updated Branches:
  refs/heads/branch-3.2 e7fba62e6 -> ff5a2cb5c


MAPREDUCE-7156. NullPointerException when reaching max shuffle connections. 
Contributed by Peter Bacsko

(cherry picked from commit ba1f9d66d94ed0b85084d7c40c09a87478b3a05a)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/ff5a2cb5
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/ff5a2cb5
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/ff5a2cb5

Branch: refs/heads/branch-3.2
Commit: ff5a2cb5c9bcbc50478c5eca16d0d7aec9701ec2
Parents: e7fba62
Author: Jason Lowe <[email protected]>
Authored: Tue Nov 6 17:55:51 2018 -0600
Committer: Jason Lowe <[email protected]>
Committed: Tue Nov 6 17:57:09 2018 -0600

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/ff5a2cb5/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
----------------------------------------------------------------------
diff --git 
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
 
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
index aeda9cc..c222685 100644
--- 
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
+++ 
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
@@ -910,6 +910,8 @@ public class ShuffleHandler extends AuxiliaryService {
     @Override
     public void channelOpen(ChannelHandlerContext ctx, ChannelStateEvent evt) 
         throws Exception {
+      super.channelOpen(ctx, evt);
+
       if ((maxShuffleConnections > 0) && (accepted.size() >= 
maxShuffleConnections)) {
         LOG.info(String.format("Current number of shuffle connections (%d) is 
" + 
             "greater than or equal to the max allowed shuffle connections 
(%d)", 
@@ -925,8 +927,6 @@ public class ShuffleHandler extends AuxiliaryService {
         return;
       }
       accepted.add(evt.getChannel());
-      super.channelOpen(ctx, evt);
-     
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to