This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 04fcbef HADOOP-16043. NPE in ITestDynamoDBMetadataStore when
fs.s3a.s3guard.ddb.table is not set.
04fcbef is described below
commit 04fcbef9c96d19ed4143c4fd63c720f00be3cdc6
Author: Gabor Bota <gabor.b...@cloudera.com>
AuthorDate: Mon Jan 14 13:12:05 2019 +0000
HADOOP-16043. NPE in ITestDynamoDBMetadataStore when
fs.s3a.s3guard.ddb.table is not set.
Contributed by Gabor Bota.
---
.../apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java | 6 ++++++
1 file changed, 6 insertions(+)
diff --git
a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
index 72863f0c..2f8146d 100644
---
a/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
+++
b/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStore.java
@@ -40,6 +40,7 @@ import
com.amazonaws.services.dynamodbv2.model.TableDescription;
import com.amazonaws.services.dynamodbv2.model.Tag;
import com.google.common.collect.Lists;
import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.StringUtils;
import org.apache.hadoop.fs.contract.s3a.S3AContract;
import org.apache.hadoop.fs.s3a.Constants;
import org.apache.hadoop.fs.s3a.Tristate;
@@ -145,7 +146,12 @@ public class ITestDynamoDBMetadataStore extends
MetadataStoreTestBase {
public static void beforeClassSetup() throws IOException {
Configuration conf = prepareTestConfiguration(new Configuration());
assumeThatDynamoMetadataStoreImpl(conf);
+ // S3GUARD_DDB_TEST_TABLE_NAME_KEY and S3GUARD_DDB_TABLE_NAME_KEY should
+ // be configured to use this test.
testDynamoDBTableName = conf.get(S3GUARD_DDB_TEST_TABLE_NAME_KEY);
+ String dynamoDbTableName = conf.getTrimmed(S3GUARD_DDB_TABLE_NAME_KEY);
+ Assume.assumeTrue("No DynamoDB table name configured", !StringUtils
+ .isEmpty(dynamoDbTableName));
// We should assert that the table name is configured, so the test should
// fail if it's not configured.
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org
