This is an automated email from the ASF dual-hosted git repository.
sunilg pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new e966edd YARN-9644. First RMContext object is always leaked during
switch over. Contributed by Bibin A Chundatt.
e966edd is described below
commit e966edd025332394701fe0d2cfa0d76731183aaf
Author: Sunil G <[email protected]>
AuthorDate: Tue Jul 2 12:18:16 2019 +0530
YARN-9644. First RMContext object is always leaked during switch over.
Contributed by Bibin A Chundatt.
---
.../apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java | 11 ++++++++---
.../hadoop/yarn/server/resourcemanager/ResourceManager.java | 11 ++++++++---
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java
index 4a5da02..8f1cda9 100644
---
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java
+++
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMNMInfo.java
@@ -25,6 +25,7 @@ import java.util.LinkedHashMap;
import java.util.List;
import javax.management.NotCompliantMBeanException;
+import javax.management.ObjectName;
import javax.management.StandardMBean;
import org.slf4j.Logger;
@@ -43,6 +44,7 @@ public class RMNMInfo implements RMNMInfoBeans {
LoggerFactory.getLogger(RMNMInfo.class);
private RMContext rmContext;
private ResourceScheduler scheduler;
+ private ObjectName mbeanObjectName;
/**
* Constructor for RMNMInfo registers the bean with JMX.
@@ -56,14 +58,17 @@ public class RMNMInfo implements RMNMInfoBeans {
StandardMBean bean;
try {
- bean = new StandardMBean(this,RMNMInfoBeans.class);
- MBeans.register("ResourceManager", "RMNMInfo", bean);
+ bean = new StandardMBean(this, RMNMInfoBeans.class);
+ mbeanObjectName = MBeans.register("ResourceManager", "RMNMInfo", bean);
} catch (NotCompliantMBeanException e) {
- LOG.warn("Error registering RMNMInfo MBean", e);
+ LOG.warn("Error registering RMNMInfo MBean", e);
}
LOG.info("Registered RMNMInfo MBean");
}
+ public void unregister() {
+ MBeans.unregister(mbeanObjectName);
+ }
static class InfoMap extends LinkedHashMap<String, Object> {
private static final long serialVersionUID = 1L;
diff --git
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
index c795bfa..6244b77 100644
---
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
+++
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
@@ -641,6 +641,7 @@ public class ResourceManager extends CompositeService
private ResourceManager rm;
private boolean fromActive = false;
private StandByTransitionRunnable standByTransitionRunnable;
+ private RMNMInfo rmnmInfo;
RMActiveServices(ResourceManager rm) {
super("RMActiveServices");
@@ -845,7 +846,7 @@ public class ResourceManager extends CompositeService
addService(proxyCAManager);
rmContext.setProxyCAManager(proxyCAManager);
- new RMNMInfo(rmContext, scheduler);
+ rmnmInfo = new RMNMInfo(rmContext, scheduler);
if (conf.getBoolean(YarnConfiguration.YARN_API_SERVICES_ENABLE,
false)) {
@@ -924,6 +925,10 @@ public class ResourceManager extends CompositeService
super.serviceStop();
DefaultMetricsSystem.shutdown();
+ // unregister rmnmInfo bean
+ if (rmnmInfo != null) {
+ rmnmInfo.unregister();
+ }
if (rmContext != null) {
RMStateStore store = rmContext.getStateStore();
try {
@@ -1182,9 +1187,9 @@ public class ResourceManager extends CompositeService
params.put("com.sun.jersey.config.property.packages", apiPackages);
}
- Builder<ApplicationMasterService> builder =
+ Builder<ResourceManager> builder =
WebApps
- .$for("cluster", ApplicationMasterService.class, masterService,
+ .$for("cluster", ResourceManager.class, this,
"ws")
.with(conf)
.withServlet("API-Service", "/app/*",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
