This is an automated email from the ASF dual-hosted git repository.
taoyang pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 3cc2135 YARN-9817. Fix failing testcases due to not initialized
AsyncDispatcher - ArithmeticException: / by zero. Contributed by Prabhu Joseph.
3cc2135 is described below
commit 3cc21350b5edbeec69fcd29aff8100b196e8f3e6
Author: Tao Yang <[email protected]>
AuthorDate: Sat Sep 7 07:39:02 2019 +0800
YARN-9817. Fix failing testcases due to not initialized AsyncDispatcher -
ArithmeticException: / by zero. Contributed by Prabhu Joseph.
---
.../src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java | 4 +++-
.../org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java | 6 +++---
.../org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java | 3 +++
3 files changed, 9 insertions(+), 4 deletions(-)
diff --git
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
index eaf1070..7e9ec7d 100644
---
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
+++
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRApp.java
@@ -208,7 +208,9 @@ public class TestMRApp {
@Test
public void testUpdatedNodes() throws Exception {
int runCount = 0;
- Dispatcher disp = Mockito.spy(new AsyncDispatcher());
+ AsyncDispatcher dispatcher = new AsyncDispatcher();
+ dispatcher.init(new Configuration());
+ Dispatcher disp = Mockito.spy(dispatcher);
MRApp app = new MRAppWithHistory(2, 2, false, this.getClass().getName(),
true, ++runCount, disp);
Configuration conf = new Configuration();
diff --git
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
index ed70a98..a846a53 100644
---
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
+++
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRuntimeEstimators.java
@@ -125,6 +125,9 @@ public class TestRuntimeEstimators {
estimator = testedEstimator;
clock = new ControlledClock();
dispatcher = new AsyncDispatcher();
+ Configuration conf = new Configuration();
+ dispatcher.init(conf);
+
myJob = null;
slotsInUse.set(0);
completedMaps.set(0);
@@ -134,8 +137,6 @@ public class TestRuntimeEstimators {
clock.tickMsec(1000);
- Configuration conf = new Configuration();
-
myAppContext = new MyAppContext(MAP_TASKS, REDUCE_TASKS);
myJob = myAppContext.getAllJobs().values().iterator().next();
@@ -162,7 +163,6 @@ public class TestRuntimeEstimators {
dispatcher.register(TaskEventType.class, new
SpeculationRequestEventHandler());
- dispatcher.init(conf);
dispatcher.start();
diff --git
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
index 8592b20..1367ff6 100644
---
a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
+++
b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
@@ -499,6 +499,8 @@ public class TestJobImpl {
// not initializing dispatcher to avoid potential race condition between
// the dispatcher thread & test thread - see MAPREDUCE-6831
AsyncDispatcher dispatcher = new AsyncDispatcher();
+ dispatcher.init(conf);
+
OutputCommitter committer = new StubbedOutputCommitter() {
@Override
@@ -959,6 +961,7 @@ public class TestJobImpl {
public void testJobPriorityUpdate() throws Exception {
Configuration conf = new Configuration();
AsyncDispatcher dispatcher = new AsyncDispatcher();
+ dispatcher.init(conf);
Priority submittedPriority = Priority.newInstance(5);
AppContext mockContext = mock(AppContext.class);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
