This is an automated email from the ASF dual-hosted git repository. dazhou pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push: new 99655167 HADOOP-16682. ABFS: Removing unnecessary toString() invocations 99655167 is described below commit 99655167f308b9c59e66b1b5d0d1fd5741cd75de Author: bilaharith <52483117+bilahar...@users.noreply.github.com> AuthorDate: Sat Jul 18 22:30:18 2020 +0530 HADOOP-16682. ABFS: Removing unnecessary toString() invocations - Contributed by Bilahari T H --- .../hadoop/fs/azurebfs/AzureBlobFileSystem.java | 8 ++++---- .../fs/azurebfs/AzureBlobFileSystemStore.java | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java index daa1905..84d6068 100644 --- a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java +++ b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java @@ -272,9 +272,9 @@ public class AzureBlobFileSystem extends FileSystem { } public boolean rename(final Path src, final Path dst) throws IOException { - LOG.debug( - "AzureBlobFileSystem.rename src: {} dst: {}", src.toString(), dst.toString()); + LOG.debug("AzureBlobFileSystem.rename src: {} dst: {}", src, dst); statIncrement(CALL_RENAME); + trailingPeriodCheck(dst); Path parentFolder = src.getParent(); @@ -778,7 +778,7 @@ public class AzureBlobFileSystem extends FileSystem { @Override public void modifyAclEntries(final Path path, final List<AclEntry> aclSpec) throws IOException { - LOG.debug("AzureBlobFileSystem.modifyAclEntries path: {}", path.toString()); + LOG.debug("AzureBlobFileSystem.modifyAclEntries path: {}", path); if (!getIsNamespaceEnabled()) { throw new UnsupportedOperationException( @@ -927,7 +927,7 @@ public class AzureBlobFileSystem extends FileSystem { */ @Override public AclStatus getAclStatus(final Path path) throws IOException { - LOG.debug("AzureBlobFileSystem.getAclStatus path: {}", path.toString()); + LOG.debug("AzureBlobFileSystem.getAclStatus path: {}", path); if (!getIsNamespaceEnabled()) { throw new UnsupportedOperationException( diff --git a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java index 74908de..66130d3 100644 --- a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java +++ b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java @@ -449,8 +449,8 @@ public class AzureBlobFileSystemStore implements Closeable { client.getFileSystem(), path, overwrite, - permission.toString(), - umask.toString(), + permission, + umask, isNamespaceEnabled); String relativePath = getRelativePath(path); @@ -903,7 +903,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "setOwner filesystem: {} path: {} owner: {} group: {}", client.getFileSystem(), - path.toString(), + path, owner, group); @@ -930,8 +930,8 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "setPermission filesystem: {} path: {} permission: {}", client.getFileSystem(), - path.toString(), - permission.toString()); + path, + permission); final AbfsRestOperation op = client.setPermission(getRelativePath(path), String.format(AbfsHttpConstants.PERMISSION_FORMAT, permission.toOctal())); @@ -952,7 +952,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "modifyAclEntries filesystem: {} path: {} aclSpec: {}", client.getFileSystem(), - path.toString(), + path, AclEntry.aclSpecToString(aclSpec)); identityTransformer.transformAclEntriesForSetRequest(aclSpec); @@ -993,7 +993,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "removeAclEntries filesystem: {} path: {} aclSpec: {}", client.getFileSystem(), - path.toString(), + path, AclEntry.aclSpecToString(aclSpec)); identityTransformer.transformAclEntriesForSetRequest(aclSpec); @@ -1034,7 +1034,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "removeDefaultAcl filesystem: {} path: {}", client.getFileSystem(), - path.toString()); + path); String relativePath = getRelativePath(path); @@ -1076,7 +1076,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "removeAcl filesystem: {} path: {}", client.getFileSystem(), - path.toString()); + path); String relativePath = getRelativePath(path); @@ -1115,7 +1115,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "setAcl filesystem: {} path: {} aclspec: {}", client.getFileSystem(), - path.toString(), + path, AclEntry.aclSpecToString(aclSpec)); identityTransformer.transformAclEntriesForSetRequest(aclSpec); @@ -1156,7 +1156,7 @@ public class AzureBlobFileSystemStore implements Closeable { LOG.debug( "getAclStatus filesystem: {} path: {}", client.getFileSystem(), - path.toString()); + path); AbfsRestOperation op = client.getAclStatus(getRelativePath(path)); AbfsHttpOperation result = op.getResult(); --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org