This is an automated email from the ASF dual-hosted git repository.
xkrogen pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-2.10 by this push:
new 79c1a93 HDFS-16181. [SBN Read] Fix display of JournalNode metric
RpcRequestCacheMissAmount (#3317)
79c1a93 is described below
commit 79c1a93bd780bb3c9332aba0725e03ac604b9fbb
Author: wangzhaohui <[email protected]>
AuthorDate: Thu Sep 16 00:56:51 2021 +0800
HDFS-16181. [SBN Read] Fix display of JournalNode metric
RpcRequestCacheMissAmount (#3317)
Co-authored-by: wangzhaohui8 <[email protected]>
(cherry picked from commit 232fd7cae170de8c6b52c14841a47dca8735c6d2)
(cherry picked from commit 2f73ac1c14dde86a5c0b86f9272cf98084478994)
(cherry picked from commit 928dbac0a627c5198b3d5884ef5a7dee3d975855)
(cherry picked from commit 9b63f601d3285c3885b2941c5874f225bfa9ab31)
---
.../org/apache/hadoop/hdfs/qjournal/server/Journal.java | 2 +-
.../hadoop/hdfs/qjournal/server/JournalMetrics.java | 16 ++++++++++------
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
index 6559a2c..5ac65b7 100644
---
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
@@ -759,7 +759,7 @@ public class Journal implements Closeable {
.setEditLog(output.toByteString())
.build();
} catch (JournaledEditsCache.CacheMissException cme) {
- metrics.rpcRequestCacheMissAmount.add(cme.getCacheMissAmount());
+ metrics.addRpcRequestCacheMissAmount(cme.getCacheMissAmount());
throw cme;
}
}
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
index c98d540..a255df2 100644
---
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
@@ -51,12 +51,7 @@ class JournalMetrics {
@Metric("Number of bytes served via RPC")
MutableCounterLong bytesServedViaRpc;
- @Metric
- MutableStat rpcRequestCacheMissAmount = new MutableStat(
- "RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
- "served due to lack of availability in cache, and how many " +
- "transactions away the request was from being in the cache.",
- "Misses", "Txns");
+ private MutableStat rpcRequestCacheMissAmount;
@Metric("Number of RPC requests with zero edits returned")
MutableCounterLong rpcEmptyResponses;
@@ -84,6 +79,11 @@ class JournalMetrics {
"syncs" + interval + "s",
"Journal sync time", "ops", "latencyMicros", interval);
}
+ rpcRequestCacheMissAmount = registry
+ .newStat("RpcRequestCacheMissAmount", "Number of RPC requests unable
to be " +
+ "served due to lack of availability in cache, and how many " +
+ "transactions away the request was from being in the cache.",
+ "Misses", "Txns");
}
public static JournalMetrics create(Journal j) {
@@ -138,4 +138,8 @@ class JournalMetrics {
q.add(us);
}
}
+
+ public void addRpcRequestCacheMissAmount(long cacheMissAmount) {
+ rpcRequestCacheMissAmount.add(cacheMissAmount);
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
