[hadoop] branch trunk updated: YARN-10909. AbstractCSQueue: Annotate all methods with VisibleForTesting that are only used by test code. Contributed by JackWangCS, Szilard Nemeth

[snemeth]

This is an automated email from the ASF dual-hosted git repository.

snemeth pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9cfd8d0  YARN-10909. AbstractCSQueue: Annotate all methods with 
VisibleForTesting that are only used by test code. Contributed by JackWangCS, 
Szilard Nemeth
9cfd8d0 is described below

commit 9cfd8d0a83fac8fd54d9d744b79c8898d7adaebe
Author: Jack <jackwan...@outlook.com>
AuthorDate: Sat Oct 23 14:47:00 2021 +0200

    YARN-10909. AbstractCSQueue: Annotate all methods with VisibleForTesting 
that are only used by test code. Contributed by JackWangCS, Szilard Nemeth
---
 .../resourcemanager/scheduler/capacity/AbstractCSQueue.java   | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
index e3feb51..e89a547 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
@@ -287,6 +287,7 @@ public abstract class AbstractCSQueue implements CSQueue {
    * Set maximum capacity - used only for testing.
    * @param maximumCapacity new max capacity
    */
+  @VisibleForTesting
   void setMaxCapacity(float maximumCapacity) {
     writeLock.lock();
     try {
@@ -1023,7 +1024,8 @@ public abstract class AbstractCSQueue implements CSQueue {
     return getEffectiveMaxCapacity(nodePartition);
   }
 
-  public boolean hasChildQueues() {
+  @VisibleForTesting
+  boolean hasChildQueues() {
     List<CSQueue> childQueues = getChildQueues();
     return childQueues != null && !childQueues.isEmpty();
   }
@@ -1608,7 +1610,7 @@ public abstract class AbstractCSQueue implements CSQueue {
             getAutoExpiredDeletionTime());
   }
 
-  public void updateLastSubmittedTimeStamp() {
+  void updateLastSubmittedTimeStamp() {
     writeLock.lock();
     try {
       usageTracker.setLastSubmittedTimestamp(Time.monotonicNow());
@@ -1617,7 +1619,8 @@ public abstract class AbstractCSQueue implements CSQueue {
     }
   }
 
-  public long getLastSubmittedTimestamp() {
+  @VisibleForTesting
+  long getLastSubmittedTimestamp() {
     readLock.lock();
 
     try {
@@ -1628,7 +1631,7 @@ public abstract class AbstractCSQueue implements CSQueue {
   }
 
   @VisibleForTesting
-  public void setLastSubmittedTimestamp(long lastSubmittedTimestamp) {
+  void setLastSubmittedTimestamp(long lastSubmittedTimestamp) {
     writeLock.lock();
     try {
       usageTracker.setLastSubmittedTimestamp(lastSubmittedTimestamp);

---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org