This is an automated email from the ASF dual-hosted git repository.
ferhui pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 8aa568c [SPS]: Fix bug for unit test of reconfiguring SPS mode (#3998)
8aa568c is described below
commit 8aa568cea5050f60dd7fbc69b60c78657da032e8
Author: litao <[email protected]>
AuthorDate: Mon Feb 28 21:03:59 2022 +0800
[SPS]: Fix bug for unit test of reconfiguring SPS mode (#3998)
---
.../apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
index fe55553..33debdb 100644
---
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
@@ -307,6 +307,8 @@ public class TestNameNodeReconfigure {
StoragePolicySatisfierMode.EXTERNAL.toString(),
nameNode.getConf().get(DFS_STORAGE_POLICY_SATISFIER_MODE_KEY,
DFS_STORAGE_POLICY_SATISFIER_MODE_DEFAULT));
+ assertNotNull("SPS Manager should be created",
+ nameNode.getNamesystem().getBlockManager().getSPSManager());
}
/**
@@ -322,6 +324,8 @@ public class TestNameNodeReconfigure {
StoragePolicySatisfierMode.NONE.toString());
verifySPSEnabled(nameNode, DFS_STORAGE_POLICY_SATISFIER_MODE_KEY,
StoragePolicySatisfierMode.NONE, false);
+ assertNull("SPS Manager should be null",
+ nameNode.getNamesystem().getBlockManager().getSPSManager());
Path filePath = new Path("/testSPS");
DistributedFileSystem fileSystem = cluster.getFileSystem();
@@ -345,7 +349,7 @@ public class TestNameNodeReconfigure {
.getNamesystem().getBlockManager().getSPSManager();
boolean isSPSRunning = spsMgr != null ? spsMgr.isSatisfierRunning()
: false;
- assertEquals(property + " has wrong value", isSPSRunning, isSPSRunning);
+ assertEquals(property + " has wrong value", isSatisfierRunning,
isSPSRunning);
String actual = nameNode.getConf().get(property,
DFS_STORAGE_POLICY_SATISFIER_MODE_DEFAULT);
assertEquals(property + " has wrong value", expected,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
