(hadoop) branch trunk updated: YARN-11705. Turn off Node Manager working directories validation by default (#6948)

[bteke]

This is an automated email from the ASF dual-hosted git repository.

bteke pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9a9ad6cc984 YARN-11705. Turn off Node Manager working directories 
validation by default (#6948)
9a9ad6cc984 is described below

commit 9a9ad6cc98438908f199c11122d8c90dfd7cc934
Author: K0K0V0K <109747532+k0k0...@users.noreply.github.com>
AuthorDate: Thu Jul 18 16:55:40 2024 +0200

    YARN-11705. Turn off Node Manager working directories validation by default 
(#6948)
    
    Change-Id: I011c13c79719be97c7ebc028804f1fdab5eb34c4
---
 .../src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java | 2 +-
 .../hadoop-yarn-common/src/main/resources/yarn-default.xml           | 2 +-
 .../apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java   | 5 +++++
 .../hadoop/yarn/server/nodemanager/TestDirectoryCollection.java      | 1 +
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
index 9503d475377..5cab8c0a9ba 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
@@ -2189,7 +2189,7 @@ public class YarnConfiguration extends Configuration {
       NM_DISK_HEALTH_CHECK_PREFIX + 
"working-dir-content-accessibility-validation.enabled";
 
   public static final boolean 
DEFAULT_NM_WORKING_DIR_CONTENT_ACCESSIBILITY_VALIDATION_ENABLED =
-      true;
+      false;
 
   /** The health checker scripts. */
   public static final String NM_HEALTH_CHECK_SCRIPTS =
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
index ac976b7472d..476789637e0 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
@@ -1998,7 +1998,7 @@
   <property>
     <description>Validate content of the node manager directories can be 
accessed</description>
     
<name>yarn.nodemanager.disk-health-checker.working-dir-content-accessibility-validation.enabled</name>
-    <value>true</value>
+    <value>false</value>
   </property>
 
   <property>
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
index a5657ab48b4..8d8e0325bd0 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DirectoryCollection.java
@@ -726,4 +726,9 @@ public class DirectoryCollection {
   public int getGoodDirsDiskUtilizationPercentage() {
     return goodDirsDiskUtilizationPercentage;
   }
+
+  @VisibleForTesting
+  public void setSubAccessibilityValidationEnabled(boolean 
subAccessibilityValidationEnabled) {
+    this.subAccessibilityValidationEnabled = subAccessibilityValidationEnabled;
+  }
 }
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDirectoryCollection.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDirectoryCollection.java
index 0193f844ac8..4dbab5be8cb 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDirectoryCollection.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestDirectoryCollection.java
@@ -528,6 +528,7 @@ public class TestDirectoryCollection {
     Files.setPosixFilePermissions(testFile.toPath(),
         PosixFilePermissions.fromString("-w--w--w-"));
     DirectoryCollection dc = new DirectoryCollection(new 
String[]{testDir.toString()});
+    dc.setSubAccessibilityValidationEnabled(true);
     Map<String, DirectoryCollection.DiskErrorInformation> 
diskErrorInformationMap =
         dc.testDirs(Collections.singletonList(testDir.toString()), 
Collections.emptySet());
     Assert.assertEquals(1, diskErrorInformationMap.size());


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org