This is an automated email from the ASF dual-hosted git repository.
sodonnell pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new df08e0de41a HDFS-17605. Reduce memory overhead of TestBPOfferService
(#6996)
df08e0de41a is described below
commit df08e0de41aa9cd85c50c0f293ae6d72b997582a
Author: Stephen O'Donnell <stephen.odonn...@gmail.com>
AuthorDate: Mon Aug 19 11:35:11 2024 +0100
HDFS-17605. Reduce memory overhead of TestBPOfferService (#6996)
---
.../org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
index fd1b5609b1f..5de131e6e41 100644
---
a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
+++
b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
@@ -144,8 +144,9 @@ public class TestBPOfferService {
mockNN2 = setupNNMock(1);
// Set up a mock DN with the bare-bones configuration
- // objects, etc.
- mockDn = Mockito.mock(DataNode.class);
+ // objects, etc. Set as stubOnly to save memory and avoid Mockito holding
+ // references to each invocation. This can cause OOM in some runs.
+ mockDn = Mockito.mock(DataNode.class, Mockito.withSettings().stubOnly());
Mockito.doReturn(true).when(mockDn).shouldRun();
Configuration conf = new Configuration();
File dnDataDir = new File(new File(TEST_BUILD_DATA, "dfs"), "data");
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org
