(hadoop) branch branch-3.4 updated: HADOOP-19377: Avoid initializing useless HashMap in protocolImplMapArray.

[cnauroth]

This is an automated email from the ASF dual-hosted git repository.

cnauroth pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new 436d87174f3 HADOOP-19377: Avoid initializing useless HashMap in 
protocolImplMapArray.
436d87174f3 is described below

commit 436d87174f3c95f7c9a6402538ecc4cccd1d4a85
Author: zhanghaobo <hfutzhan...@163.com>
AuthorDate: Thu Feb 13 20:14:40 2025 +0000

    HADOOP-19377: Avoid initializing useless HashMap in protocolImplMapArray.
    
    Closes #6927
    
    Signed-off-by: Chris Nauroth <cnaur...@apache.org>
    (cherry picked from commit c4dace07719991eb6431eacba1ac4a9fd735e1e7)
---
 .../hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java   | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
 
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
index c7ca09c60ba..5dcbe9027e8 100644
--- 
a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
+++ 
b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
@@ -90,7 +90,7 @@ public enum RpcKind {
     RPC_BUILTIN ((short) 1),         // Used for built in calls by tests
     RPC_WRITABLE ((short) 2),        // Use WritableRpcEngine 
     RPC_PROTOCOL_BUFFER ((short) 3); // Use ProtobufRpcEngine
-    final static short MAX_INDEX = RPC_PROTOCOL_BUFFER.value; // used for 
array size
+    final static short MAX_SIZE = RPC_PROTOCOL_BUFFER.value; // used for array 
size
     private final short value;
 
     RpcKind(short val) {
@@ -1085,11 +1085,12 @@ public boolean isShadedPBImpl() {
    }
 
    ArrayList<Map<ProtoNameVer, ProtoClassProtoImpl>> protocolImplMapArray = 
-       new ArrayList<Map<ProtoNameVer, 
ProtoClassProtoImpl>>(RpcKind.MAX_INDEX);
-   
+       new ArrayList<Map<ProtoNameVer, ProtoClassProtoImpl>>(RpcKind.MAX_SIZE);
+
+   @SuppressWarnings("checkstyle:Indentation")
    Map<ProtoNameVer, ProtoClassProtoImpl> getProtocolImplMap(RPC.RpcKind 
rpcKind) {
      if (protocolImplMapArray.size() == 0) {// initialize for all rpc kinds
-       for (int i=0; i <= RpcKind.MAX_INDEX; ++i) {
+       for (int i = 0; i < RpcKind.MAX_SIZE; ++i) {
          protocolImplMapArray.add(
              new HashMap<ProtoNameVer, ProtoClassProtoImpl>(10));
        }


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org