This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new 91e6045803d HADOOP-19567. S3A: error stack traces printed on analytics
stream factory close (#7701)
91e6045803d is described below
commit 91e6045803d4326da612f09e11e855bece31b028
Author: Steve Loughran <ste...@cloudera.com>
AuthorDate: Fri May 23 13:26:44 2025 +0100
HADOOP-19567. S3A: error stack traces printed on analytics stream factory
close (#7701)
Contributed by Steve Loughran
---
.../hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java
index 102d31a4f12..c67c08be7b9 100644
---
a/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java
+++
b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java
@@ -21,6 +21,8 @@
import java.io.IOException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import software.amazon.s3.analyticsaccelerator.S3SdkObjectClient;
import
software.amazon.s3.analyticsaccelerator.S3SeekableInputStreamConfiguration;
import software.amazon.s3.analyticsaccelerator.S3SeekableInputStreamFactory;
@@ -40,6 +42,8 @@
* {@code S3AStore}, if fs.s3a.input.stream.type is set to Analytics.
*/
public class AnalyticsStreamFactory extends AbstractObjectInputStreamFactory {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(AnalyticsStreamFactory.class);
private S3SeekableInputStreamConfiguration seekableInputStreamConfiguration;
private LazyAutoCloseableReference<S3SeekableInputStreamFactory>
s3SeekableInputStreamFactory;
@@ -98,7 +102,11 @@ public StreamFactoryRequirements factoryRequirements() {
@Override
protected void serviceStop() throws Exception {
- this.s3SeekableInputStreamFactory.close();
+ try {
+ s3SeekableInputStreamFactory.close();
+ } catch (Exception ignored) {
+ LOG.debug("Ignored exception while closing stream factory", ignored);
+ }
callbacks().incrementFactoryStatistic(ANALYTICS_STREAM_FACTORY_CLOSED);
super.serviceStop();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org
