This is an automated email from the ASF dual-hosted git repository.
gaurava pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 729f19f2339 HADOOP-19603. Fix TestFsShellList.testList on Windows
(#7771)
729f19f2339 is described below
commit 729f19f233948b8472874cf7e2b65d3b33cd2ec6
Author: Gautham B A <gautham.bangal...@gmail.com>
AuthorDate: Fri Jul 11 00:31:38 2025 +0530
HADOOP-19603. Fix TestFsShellList.testList on Windows (#7771)
* The test
`org.apache.hadoop.fs.TestFsShellList#testList`
creates files with special characters and
tries to list them using `ls`.
* Filenames with special characters aren't
allowed on Windows.
* Thus, we need to modify the test to only
test for non-special characters on Windows
and include the filenames with special
characters on non-Windows environments.
---
.../src/test/java/org/apache/hadoop/fs/TestFsShellList.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellList.java
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellList.java
index c2a3a1c1efd..46ab48ab108 100644
---
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellList.java
+++
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellList.java
@@ -66,9 +66,12 @@ public void testList() throws Exception {
String[] lsArgv = new String[]{"-ls", testRootDir.toString()};
assertThat(shell.run(lsArgv)).isEqualTo(0);
- createFile(new Path(testRootDir, "abc\bd\tef"));
+ if (!Path.WINDOWS) {
+ createFile(new Path(testRootDir, "abc\bd\tef"));
+ createFile(new Path(testRootDir, "qq\r123"));
+ }
+
createFile(new Path(testRootDir, "ghi"));
- createFile(new Path(testRootDir, "qq\r123"));
lsArgv = new String[]{"-ls", testRootDir.toString()};
assertThat(shell.run(lsArgv)).isEqualTo(0);
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-commits-h...@hadoop.apache.org
