----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/908/ -----------------------------------------------------------
Review request for hadoop-common. Summary ------- HDFS-1788 FsShell ls: Show symlinks properties I need some suggestions about: 1 Should PathData hold a FileSystem also? 2 The symlink target is not exists or permission deny, should ls -L shows a blink text? It seems no way get a FileStatus of link target without access it. Diffs ----- http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/FileContext.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/FsShell.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/FsShellPermissions.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/LocalFileSystem.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Command.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/CommandWithDestination.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/CopyCommands.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Count.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Delete.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Display.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/FsUsage.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Ls.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Mkdir.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/MoveCommands.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/PathData.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/SetReplication.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Stat.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Tail.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Test.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Touchz.java 1135949 http://svn.apache.org/repos/asf/hadoop/common/trunk/common/src/test/core/org/apache/hadoop/fs/shell/TestPathData.java 1135949 Diff: https://reviews.apache.org/r/908/diff Testing ------- Thanks, Bochun
