----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/884/ -----------------------------------------------------------
(Updated 2011-06-16 12:13:34.081758) Review request for hadoop-common and Todd Lipcon. Changes ------- Throw exceptions (getting rid of nulls). Add appropriate javadocs and fix one checkstyle nit. Summary ------- Since getSerialization() can possibly return a null, it is only right that getSerializer() and getDeserializer() usage functions do the same, instead of throwing up NPEs. Related issue to which this improvement is required: https://issues.apache.org/jira/browse/MAPREDUCE-2584 This addresses bug HADOOP-7328. http://issues.apache.org/jira/browse/HADOOP-7328 Diffs (updated) ----- src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee314a Diff: https://reviews.apache.org/r/884/diff Testing ------- Existing SequenceFile serialization factory tests pass. The change is merely to make the functions return null instead of throwing an NPE within. Thanks, Harsh
