Ivan A. Veselovsky created HADOOP-9104: ------------------------------------------
Summary: Should org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) reject addition if a renew action for this FS is already present in the queue? Key: HADOOP-9104 URL: https://issues.apache.org/jira/browse/HADOOP-9104 Project: Hadoop Common Issue Type: Improvement Reporter: Ivan A. Veselovsky The issue extrected from discussion in https://issues.apache.org/jira/browse/HADOOP-9046 . Currently the method org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) allows to add any number of renew actions for the same FS. Question #1: are there real usecases when this can make sense? Also, when we remove a renew action with org.apache.hadoop.fs.DelegationTokenRenewer.removeRenewAction(T), we iterate over all the actions in the queue, and remove the first one with matching FS, if any. So, in case if several actions submitted for the same FS, not more than one action will be removed upon #removeRenewAction() invocation. So, to remove all them a developer will need a cycle. So, if the answer to the question #1 is true, may be we should change the #removeRenewAction(FS) behavior to remove all actions associated with this FS, or add #removeAllRenewActuions(FS)? This is question #2. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira