Liang Xie created HADOOP-10953: ---------------------------------- Summary: a minor concurrent bug inside NetworkTopology Key: HADOOP-10953 URL: https://issues.apache.org/jira/browse/HADOOP-10953 Project: Hadoop Common Issue Type: Bug Components: net Affects Versions: 3.0.0 Reporter: Liang Xie Assignee: Liang Xie Priority: Minor
Found this issue while reading the related code. In NetworkTopology.toString() method, there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove, most of this.toString() calls are protected by rwlock, except a couple of error handling codes, one possible fix is that moving them into lock as well, due to not heavy operations, so no obvious downgration should be observed per my current knowledge. -- This message was sent by Atlassian JIRA (v6.2#6252)