+1 to treating it as a bug in Hadoop code if a test writes a file outside of the target directory. This has the side effect that "mvn clean" doesn't really clean up fully.
HADOOP-12519 is a recent patch I committed to fix this kind of problem in hadoop-azure. Let's follow up with similar fixes in hadoop-hdfs tests and anywhere else needed. --Chris Nauroth On 10/29/15, 4:44 AM, "Sean Busbey" <bus...@cloudera.com> wrote: >In Maven projects, all build generated files (including test working >space) >is supposed to be under directories named 'target'. > >I believe a few folks already have an issue open to correct the HDFS >tests: > >https://issues.apache.org/jira/browse/HDFS-9263 > >Please make sure these incorrect paths are covered there. > >-- >Sean >On Oct 29, 2015 3:14 AM, "Vinayakumar B" <vinayakum...@apache.org> wrote: > >> Thanks, >> >> In HDFS precommmit builds we can see ASF licence check. >> HDFS uses <hadoop-hdfs>/build as a test directory for some tests, I >>think >> this is an exception case. >> >> >> >>https://builds.apache.org/job/PreCommit-HDFS-Build/13268/artifact/patchpr >>ocess/patch-asflicense-problems.txt >> >> Regards, >> Vinay >> >> On Thu, Oct 29, 2015 at 9:48 AM, Sean Busbey <bus...@cloudera.com> >>wrote: >> >> > On Wed, Oct 28, 2015 at 9:23 PM, Vinayakumar B >><vinayakum...@apache.org> >> > wrote: >> > > So I¹m going to turn on Yetus for *ALL* Hadoop precommit jobs >> > >> later tonight. (Given how backed up Jenkins is at the moment, >>there is >> > >> plenty of time. haha) Anyway, if you see ³Powered by Yetus² in the >> > Hadoop >> > >> QA posts, you¹ve got Yetus. If you don¹t see it, it ran on trunk¹s >> > >> test-patch. >> > > >> > > +1, >> > > >> > > Report looks very clean, and multiple JDK runs helps as well. Also >> > parallel >> > > run is enabled for HDFS precommit as well. >> > > >> > > One issue, Looks like ASF licence check is done on files in build >> > directory >> > > also, which generates too many errors. Just need to skip this >> directory. >> > > >> > > Regards, >> > > Vinay >> > > >> > > >> > >> > Yetus should not be running ASF license checks inside of build >> > directories. If you can point to a specific job where this happens >> > please either file a jira against Yetus or let Allen or I know so we >> > can file it. >> > >> > At a quick glance, I see ASF license failures on HADOOP-9613, but >> > looking at the flagged files: >> > >> > >> > >> >>https://builds.apache.org/job/PreCommit-HADOOP-Build/7966/artifact/patchp >>rocess/patch-asflicense-problems.txt >> > >> > It is dumping test files outside of the target/ directory, so those >> > files are legitimately in the source tree. >> > >> > >> > -- >> > Sean >> > >>
