linbao111 created HADOOP-13240:
----------------------------------

             Summary: TestAclCommands.testSetfaclValidations fail
                 Key: HADOOP-13240
                 URL: https://issues.apache.org/jira/browse/HADOOP-13240
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 2.7.2, 2.4.1
         Environment: hadoop 2.4.1,as6.5
            Reporter: linbao111
            Priority: Minor


mvn test -Djava.net.preferIPv4Stack=true -Dlog4j.rootLogger=DEBUG,console 
-Dtest=TestAclCommands#testSetfaclValidations failed with following message:
-------------------------------------------------------------------------------
Test set: org.apache.hadoop.fs.shell.TestAclCommands
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.599 sec <<< 
FAILURE! - in org.apache.hadoop.fs.shell.TestAclCommands
testSetfaclValidations(org.apache.hadoop.fs.shell.TestAclCommands)  Time 
elapsed: 0.534 sec  <<< FAILURE!
java.lang.AssertionError: setfacl should fail ACL spec missing
        at org.junit.Assert.fail(Assert.java:93)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertFalse(Assert.java:68)
        at 
org.apache.hadoop.fs.shell.TestAclCommands.testSetfaclValidations(TestAclCommands.java:81)

i notice from 
HADOOP-10277,hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/AclEntry.java
 code changed

should 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.javabe
 changed to:
diff --git 
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
 b/hadoop-common-project/hadoop-common/src/test/java/org/
old mode 100644
new mode 100755
index b14cd37..463bfcd
--- 
a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
+++ 
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
@@ -80,7 +80,7 @@ public void testSetfaclValidations() throws Exception {
             "/path" }));
     assertFalse("setfacl should fail ACL spec missing",
         0 == runCommand(new String[] { "-setfacl", "-m",
-            "", "/path" }));
+            ":", "/path" }));
   }
 
   @Test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Reply via email to