Mingliang Liu created HADOOP-13288:
--------------------------------------

             Summary: Guard null stats key in FileSystemStorageStatistics
                 Key: HADOOP-13288
                 URL: https://issues.apache.org/jira/browse/HADOOP-13288
             Project: Hadoop Common
          Issue Type: Sub-task
            Reporter: Mingliang Liu
            Assignee: Mingliang Liu


Currently in {{FileSystemStorageStatistics}} we simply returns data from 
{{FileSystem#Statistics}}. However there is no null key check, which leads to  
NPE problems to downstream applications. For example, we got a NPE when passing 
a null key to {{FileSystemStorageStatistics#getLong()}}, exception stack as 
following:
{quote}
NullPointerException
at 
org.apache.hadoop.fs.FileSystemStorageStatistics.fetch(FileSystemStorageStatistics.java:80)
at 
org.apache.hadoop.fs.FileSystemStorageStatistics.getLong(FileSystemStorageStatistics.java:108)
at 
org.apache.tez.runtime.metrics.FileSystemStatisticsUpdater2.updateCounters(FileSystemStatisticsUpdater2.java:60)
at 
org.apache.tez.runtime.metrics.TaskCounterUpdater.updateCounters(TaskCounterUpdater.java:118)
at org.apache.tez.runtime.RuntimeTask.setFrameworkCounters(RuntimeTask.java:172)
at 
org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:100)
at 
org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:37)
at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{quote}

This jira is to add null stat key check to {{FileSystemStorageStatistics}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Reply via email to