Thank you for your questions!
> So, this is my request for comments on these questions:
> * Is there any interest in this at all?
> ** "This" being patches for code style & things like FindBugs & Checkstyle
Yes. I'm interested in this.
> * Size of the patches: Rather one big patch or smaller ones (e.g. per file
> or package)
Par file or package is fine.
Bigger patch makes review harder,
and if your patch is big, you will need to rebase it frequently :(
> * Anyone willing to help me with this? e.g. reviewing and committing?
Yes, please send an e-mail to dev ML or ping me if your patches are not
reviewed from anyone.
On 2017/08/07 21:13, Lars Francke wrote:
a few words about me: I've contributed to Hadoop (and it's ecosystem) in
the past am a Hive committer and have used Hadoop for 10 years now, so I'm
not totally inexperienced. I'm earning my money as a Hadoop consultant so
I've seen dozens of real-life clusters in my life.
As part of a few recent client projects and now writing about Hadoop in a
new project/book I'm digging into the source code to figure out some of the
things that are not documented.
But as part of this digging I'm seeing lots of warnings in the code,
inconsistencies etc. and I'd like to contribute some fixes to this back to
I have been a long-time believer in good code quality and consistent code
styles. This might affect people like me especially who do a lot of
"drive-by" contributions as I'm not someone who looks at the code daily but
comes across it reasonably often as part of client engagements. In those
scenarios, it's very unhelpful to have inconsistent code & bad
Two simple but concrete examples:
* There's lots of "final" usages on variables and methods but no
consistency. Was this done for particular reasons or personal preference?
* Similarly, there's lots of things that are public or protected while they
could in theory be private. This especially makes it very hard to reason
Judging from the current code there's lots of "unofficial" code styling
and/or personal preference. The Wiki says to follow the Sun
guidelines which have not been updated in almost 20 years. A new version
is in the works an clarifies a lot of things. I'm trying to get it
published soon. I'd try to format according to the latter (that means among
other things no "final" for local variables).
I realize that I won't be able to single-handedly fix all of this
especially as code gets contributed but if the community thinks it's
worthwhile I'd still love to land a few cleanup patches. My experience in
the past has been that it's hard to get attention to these things (which I
fully understand as they take up someone's time to review & commit).
So, this is my request for comments on these questions:
* Is there any interest in this at all?
** "This" being patches for code style & things like FindBugs & Checkstyle
* Size of the patches: Rather one big patch or smaller ones (e.g. per file
* Anyone willing to help me with this? e.g. reviewing and committing? I'd
be more than happy to bribe you with drinks, sweets, food or something else
My plan is not to go through each and every file and fix every issue I see.
But there are some specific areas I'm looking at in detail and there I'd
love to contribute back.
Thank you for reading!
PS: Posting to common-dev only, not sure if I should cross post to hdfs-dev
and yarn-dev as well?
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org