saintstack commented on a change in pull request #3: HADOOP-16821. [pb-upgrade] Use 'o.a.h.thirdparty.protobuf' shaded prefix instead of 'protobuf_3_7' URL: https://github.com/apache/hadoop-thirdparty/pull/3#discussion_r369145377
########## File path: src/site/markdown/index.md.vm ########## @@ -43,3 +43,4 @@ This page provides an overview of the major changes. Protobuf-java ------------- Google Protobuf's 3.7.1 jar is available as *org.apache.hadoop.thirdparty:hadoop-shaded-protobuf_3_7* artifact. Review comment: Remove the version from artifact specifier too? Will be odd if you upgrade to pb 2.8 but you specify the dependency referring to hadoop-shaded-protobuf_3_7 ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
