Ahmed Hussein created HADOOP-17098:

             Summary: Reduce Guava dependency in Hadoop source code
                 Key: HADOOP-17098
                 URL: https://issues.apache.org/jira/browse/HADOOP-17098
             Project: Hadoop Common
          Issue Type: Task
            Reporter: Ahmed Hussein
            Assignee: Ahmed Hussein

Relying on Guava implementation in Hadoop has been painful due to compatibility 
and vulnerability issues.
 Guava updates tend to break/deprecate APIs. This made It hard to maintain 
backward compatibility within hadoop versions and clients/downstreams.

With 3.x uses java8+, the java 8 features should preferred to Guava, reducing 
the footprint, and giving stability to source code.

This jira should serve as an umbrella toward an incremental effort to reduce 
the usage of Guava in the source code and to create subtasks to replace Guava 
classes with Java features.

Furthermore, it will be good to add a rule in the pre-commit build to warn 
against introducing a new Guava usage in certain modules.

Any one willing to take part in this code refactoring has to:
 # Focus on one module at a time in order to reduce the conflicts and the size 
of the patch. This will significantly help the reviewers.
 # Run all the unit tests related to the module being affected by the change. 
It is critical to verify that any change will not break the unit tests, or 
cause a stable test case to become flaky.


A list of sub tasks replacing Guava APIs with java8 features:
com.google.common.io.BaseEncoding#base64()      java.util.Base64
com.google.common.io.BaseEncoding#base64Url()   java.util.Base64
java.lang.String#join() or 
com.google.common.base.Optional#of()                    java.util.Optional#of()
com.google.common.base.Optional#fromNullable()  java.util.Optional#ofNullable()
com.google.common.base.Optional                         java.util.Optional

I also vote for the replacement of {{Precondition}} with either a wrapper, or 
Apache commons lang.

I believe you guys have dealt with Guava compatibilities in the past and 
probably have better insights. Any thoughts? [~weichiu], [~gabor.bota], 
[~ste...@apache.org], [~ayushtkn], [~busbey], [~jeagles], [~kihwal]


This message was sent by Atlassian Jira

To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Reply via email to