Marcono1234 created HADOOP-17530: ------------------------------------ Summary: Two tests perform faulty assertEquals calls comparing variable with itself Key: HADOOP-17530 URL: https://issues.apache.org/jira/browse/HADOOP-17530 Project: Hadoop Common Issue Type: Bug Reporter: Marcono1234
The following test classes perform faulty {{assertEquals}} calls which erroneously compare a variable with itself. - {{org.apache.hadoop.hdfs.server.namenode.TestNameNodeReconfigure}} https://github.com/apache/hadoop/blob/c3134ab3a99d4109d9ae3fcf216018351eb1d36f/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java#L342 {code} assertEquals(property + " has wrong value", isSPSRunning, isSPSRunning); {code} - {{org.apache.hadoop.hdfs.server.namenode.TestNameNodeReconfigure}} https://github.com/apache/hadoop/blob/c3134ab3a99d4109d9ae3fcf216018351eb1d36f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java#L222 {code} Assert.assertEquals(scIdResult, scIdResult); {code} It would be good if you could create a pull request for this because I am not very familiar with the project. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org