I think we usually merge backport without explicit +1 if the conflict is trivial, same as done on JIRA-only workflow (on which we attached patch like HADOOP-xxx-branch-3.3.001.patch for precommit check then commit it without explicit +1).
If committers want review since the change is not trivial, backporting PR might tend to be ignored without explicit request. There seems to be no clear statement about approving backports on HowToCommit wiki. https://cwiki.apache.org/confluence/display/HADOOP2/HowToCommit On 2021/06/02 13:43, Wei-Chiu Chuang wrote:
I'm curious about the GitHub PR conventions we use today... say I want to backport a commit from trunk to branch-3.3, and there's a small code conflict so I push a PR against branch-3.3 using GitHub to go through the precommit check. Do I need explicit approval from another committer to merge the backport PR? (As.a committer, I know I can merge at any time) or can I merge when the precommit comes back okay?
--------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
