Jose Luis López created HADOOP-19983:
----------------------------------------
Summary: Re-enable TestLogAggregationService in GHA
Key: HADOOP-19983
URL: https://issues.apache.org/jira/browse/HADOOP-19983
Project: Hadoop Common
Issue Type: Sub-task
Components: common, test
Reporter: Jose Luis López
h3. Depends on
HADOOP-19979. Do not commit until that has merged.
h3. What
Remove one entry from \{{.github/gha-tests/exclude-tests.txt}}:
*
\{{**/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java}}
h3. Why
HADOOP-19979 fixed an observed race in \{{verifyLocalFileDeletion}}.
{\{testLocalFileDeletionAfterUpload}} waited for each log file to disappear and
then asserted on the enclosing directory with no wait of its own. The container
files and the application directory are removed by two independent
FileDeletionTasks scheduled on the DeletionService pool with no ordering
between them, so the directory assertion could run before its task had
finished. Measured at 4 of the 60 most recent PRs, including unrelated ones.
The fix waits for \{{app1LogDir}} to disappear, which subsumes the per-file
waits since the files live inside it.
h3. Residual risk
The fix covers \{{verifyLocalFileDeletion}}, used by 3 of the class's 49 tests;
the remaining tests are untouched. Roughly 30 methods carry an explicit
{\{@Timeout}}, but hadoop-yarn-server-nodemanager has no module-wide
{\{junit.jupiter.execution.timeout.default}} equivalent to the one HDFS-17957
added for hadoop-hdfs, so a hang in this class still costs the fork rather than
surfacing as a named failure.
The class runs in the \{{common}} matrix entry
(\{{-pl :hadoop-common -pl :hadoop-yarn-server-nodemanager -pl
:hadoop-yarn-client -pl :hadoop-distcp}}).
HADOOP-19979 also fixes TestSSLHttpServerMTLS in hadoop-common, which shares
that entry, so the entry as a whole should be quieter than it was.
h3. Acceptance criteria
Five consecutive successful GHA runs with the entry removed, per
{\{.github/gha-tests/README.md}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
